Build on JRuby again #1383

vincent-psarga · 2020-01-13T16:06:00Z

Summary

Thanks to the generation of Protobuffers in pure Ruby, we should be able to build cucumber on JRuby again.

Details

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Refactor (code change that does not change external functionality)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

I've added tests for my code
My change requires a change to the documentation.
I have updated the documentation accordingly.

This reverts commit e349710.

olleolleolle · 2020-01-13T16:09:40Z

(I made edits to the title and description, to account for the J of JRuby.)

vincent-psarga · 2020-01-13T16:28:14Z

(I made edits to the title and description, to account for the J of JRuby.)

Thanks, I did that PR a bit too quickly :/

luke-hill · 2020-01-14T09:38:10Z

This PR also lends itself to perhaps (either alongside or simultaneously), removing appveyor and getting circleci to build windows. That's where the failures are most prevalent, JRuby and windows.

Note: this may definitelly not be the best way to proceed, but the long term idea is to drop the `step` nesting, so spending time fixing this issue would be lost.

vincent-psarga · 2020-01-14T10:18:09Z

Note: I disabled one of the scenario to make this work (features/docs/defining_steps/nested_steps.feature:111 which involves using step.
As the long term idea is to disable nesting steps(see #1362), spending time fixing this seems counter productive. That said, if someone knows how to get this scenario pass again, feel free :)

I also had to tweak a bit one test. If seems that Ruby does not set RbConfig::CONFIG['rubyarchdir'] which is used by BacktraceFilter. It seemed logical that the unit test also checked if this was set.

vincent-psarga · 2020-01-14T10:21:47Z

This PR also lends itself to perhaps (either alongside or simultaneously), removing appveyor and getting circleci to build windows. That's where the failures are most prevalent, JRuby and windows.

Getting the build running on CircleCI/Windows (and removing AppVeyor) is planned yes, but not in this PR.
The idea here is simply to activate JRuby again (as the cucumber-messages gem now uses a pure Ruby Protobuffers handling).

luke-hill · 2020-01-14T10:31:36Z

It's failing for russian letters being converted somewhere.

The good news is all of the main scenarios pass. It's the language specific ones that come up smelly fishy

vincent-psarga · 2020-01-14T14:50:39Z

Ok, I've spent a fair amount of time on trying to figure out why this fails but don't get anywhere. If anyone has a deeper knowledge of JRuby and/or why this may happen, have fun :)

The only way I add to get it working was to replace content of examples/i18n/ru/step_definitions/calculator_steps.rb with:

Given('я ввожу число {int}') do |number|
  calc.push number
end

Given('затем ввожу число {int}') do |number|
  calc.push number
end

When('нажимаю {string}') do |operation|
  calc.send operation
end

When('я нажимаю {string}') do |operation|
  calc.send operation
end

Then('результатом должно быть число {float}') do |expected|
  calc.result.should == expected
end

Given('я сложил {int} и {int}') do |first_number, second_number|
  calc.push first_number
  calc.push second_number
  calc.send '+'
end

But that's definitely cheating :/

vincent-psarga · 2020-01-14T14:55:48Z

Oh and if someone want to figure that out, bumping to 9.2.9 does not help (the same error is there)

Remove useless reference to protobuf gem for JRuby

vincent-psarga · 2020-02-26T14:21:22Z

Ok, this I've disabled a few examples for i18n and JRuby (namely 'ru', 'uk' and 'uz') as we can't define step definitions there (note that Greek or Japanese work).

I think it's more an issue with JRuby than with Cucumber. I was thinking about adding a file under 'docs/jruby-limitations.md' (which would be linked from the README) telling that we can not use keywords as step definitions for those languages (in the ruby code, the features files still support those)

Would that be enough to merge this PR ?

olleolleolle

Awesome!

docs/jruby-limitations.md

Co-Authored-By: Olle Jonsson <[email protected]>

vincent-psarga · 2020-02-26T15:33:56Z

Thanks for the corrections :)
(and I'm scared to be able to do one click commits from Github interface :D )

luke-hill

Is there a reason we document 9.2 but run CI against 9.1?? I don't use JRuby so there may be an obvious reason

luke-hill · 2020-02-26T15:34:16Z

examples/i18n/Rakefile

+end
+
+def jruby_disabled_examples?(lang)
+  return unless RUBY_PLATFORM == 'java'


rubocop will flag this. Linespace after guard clause.

olleolleolle · 2020-02-26T15:37:54Z

README.md

@@ -28,7 +28,7 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for info on contributing to Cucumber.
 * Ruby 2.5
 * Ruby 2.4
 * Ruby 2.3
-* JRuby 9.1
+* JRuby 9.1 (with [some limitations](https://github.com/cucumber/cucumber-ruby/blob/master/docs/jruby-limitations.md))


Perhaps "JRuby 9.1, 9.2"?

Suggested change

* JRuby 9.1 (with [some limitations](https://github.com/cucumber/cucumber-ruby/blob/master/docs/jruby-limitations.md))

* JRuby 9.1, JRuby 9.2 (with [some limitations](https://github.com/cucumber/cucumber-ruby/blob/master/docs/jruby-limitations.md))

It may be worth checking it still build with JRuby 9.1, but that's just a task to add to CircleCI, should not be much of a trouble.
I'll add that :)

olleolleolle · 2020-02-26T15:44:20Z

docs/jruby-limitations.md

@@ -1,6 +1,6 @@
 # Cucumber and JRuby limitations

-`cucumber` can be executed on `JRuby` (tested with `9.2.8.0`), although some of the features
+`cucumber` can be executed on `JRuby` (tested with `9.1`and `9.2`), although some of the features


Suggested change

`cucumber` can be executed on `JRuby` (tested with `9.1`and `9.2`), although some of the features

`cucumber` can be executed on `JRuby` (tested with `9.1` and `9.2`), although some of the features

well, it seems we have even more problems with JRuby 9.1 (apparently it's failing with language he).
I guess it's safer to just indicate 9.2

vincent-psarga · 2020-02-26T16:02:31Z

Is there a reason we document 9.2 but run CI against 9.1?? I don't use JRuby so there may be an obvious reason

I bumped to 9.2 but forgot to update the documentation (which is done now).
No better reason than human error :D

Revert "Do not build JRuby on CI as it is not supported anymore"

48dc0c7

This reverts commit e349710.

olleolleolle changed the title ~~Build on Ruby again~~ Build on JRuby again Jan 13, 2020

vincent-psarga added 2 commits January 14, 2020 11:01

Do not add RbConfig keys that are not available

7d4d7bf

Disable one failing scenario on JRuby

4d3e882

Note: this may definitelly not be the best way to proceed, but the long term idea is to drop the `step` nesting, so spending time fixing this issue would be lost.

vincent-psarga added 5 commits February 24, 2020 16:01

Merge branch 'master' into enable-jruby-ci-again

e0066cf

Disable Russian example with JRuby

cc248d7

Remove useless reference to protobuf gem for JRuby

Also disable UK examples for JRuby

4285973

Fix offenses

af11161

Also disable UZ for JRuby i18n examples

18d2bfe

Add descriptions for JRuby limitations

73ae38e

olleolleolle approved these changes Feb 26, 2020

View reviewed changes

docs/jruby-limitations.md Outdated Show resolved Hide resolved

docs/jruby-limitations.md Outdated Show resolved Hide resolved

vincent-psarga and others added 2 commits February 26, 2020 16:31

Update docs/jruby-limitations.md

835d765

Co-Authored-By: Olle Jonsson <[email protected]>

Update docs/jruby-limitations.md

a216105

Co-Authored-By: Olle Jonsson <[email protected]>

luke-hill reviewed Feb 26, 2020

View reviewed changes

olleolleolle reviewed Feb 26, 2020

View reviewed changes

Build JRUby 9.1 and 9.2

a59ea7f

olleolleolle reviewed Feb 26, 2020

View reviewed changes

vincent-psarga added 2 commits February 26, 2020 16:44

Fix CircleCI config

86b5d47

Disable building on JRUby 9.1 as it fails with more languages

4c83414

vincent-psarga merged commit 190ffb0 into master Feb 28, 2020

luke-hill deleted the enable-jruby-ci-again branch August 22, 2023 11:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build on JRuby again #1383

Build on JRuby again #1383

vincent-psarga commented Jan 13, 2020 •

edited by olleolleolle

Loading

olleolleolle commented Jan 13, 2020

vincent-psarga commented Jan 13, 2020

luke-hill commented Jan 14, 2020

vincent-psarga commented Jan 14, 2020

vincent-psarga commented Jan 14, 2020

luke-hill commented Jan 14, 2020

vincent-psarga commented Jan 14, 2020

vincent-psarga commented Jan 14, 2020

vincent-psarga commented Feb 26, 2020

olleolleolle left a comment

vincent-psarga commented Feb 26, 2020

luke-hill left a comment

luke-hill Feb 26, 2020

olleolleolle Feb 26, 2020

vincent-psarga Feb 26, 2020

olleolleolle Feb 26, 2020

vincent-psarga Feb 26, 2020

vincent-psarga commented Feb 26, 2020

	* JRuby 9.1 (with [some limitations](https://github.com/cucumber/cucumber-ruby/blob/master/docs/jruby-limitations.md))
	* JRuby 9.1, JRuby 9.2 (with [some limitations](https://github.com/cucumber/cucumber-ruby/blob/master/docs/jruby-limitations.md))

	`cucumber` can be executed on `JRuby` (tested with `9.1`and `9.2`), although some of the features
	`cucumber` can be executed on `JRuby` (tested with `9.1` and `9.2`), although some of the features

Build on JRuby again #1383

Build on JRuby again #1383

Conversation

vincent-psarga commented Jan 13, 2020 • edited by olleolleolle Loading

Summary

Details

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

olleolleolle commented Jan 13, 2020

vincent-psarga commented Jan 13, 2020

luke-hill commented Jan 14, 2020

vincent-psarga commented Jan 14, 2020

vincent-psarga commented Jan 14, 2020

luke-hill commented Jan 14, 2020

vincent-psarga commented Jan 14, 2020

vincent-psarga commented Jan 14, 2020

vincent-psarga commented Feb 26, 2020

olleolleolle left a comment

Choose a reason for hiding this comment

vincent-psarga commented Feb 26, 2020

luke-hill left a comment

Choose a reason for hiding this comment

luke-hill Feb 26, 2020

Choose a reason for hiding this comment

olleolleolle Feb 26, 2020

Choose a reason for hiding this comment

vincent-psarga Feb 26, 2020

Choose a reason for hiding this comment

olleolleolle Feb 26, 2020

Choose a reason for hiding this comment

vincent-psarga Feb 26, 2020

Choose a reason for hiding this comment

vincent-psarga commented Feb 26, 2020

vincent-psarga commented Jan 13, 2020 •

edited by olleolleolle

Loading