Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicated query pairs from login options #35

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

mh84
Copy link
Contributor

@mh84 mh84 commented Mar 10, 2024

As options in line 592 are now already the config.default_login_options, the removed lines will lead to duplicated query pairs, this pr will fix this.

Copy link
Owner

@ctron ctron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the PR! ❤️

@ctron
Copy link
Owner

ctron commented Mar 11, 2024

Looks like I need to uptick the MSRV again.

@ctron ctron merged commit 369c687 into ctron:main Mar 11, 2024
1 of 3 checks passed
@ctron
Copy link
Owner

ctron commented Mar 11, 2024

I released it as 0.10.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants