Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repair memory leak for applierserver #911

Merged
merged 1 commit into from
Dec 16, 2024
Merged

repair memory leak for applierserver #911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 5 additions & 34 deletions ...redis-keeper/src/main/java/com/ctrip/xpipe/redis/keeper/applier/DefaultApplierServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public class DefaultApplierServer extends AbstractInstanceNode implements Applie
public ApplierLwmManager lwmManager;*/

@InstanceDependency
public AtomicReference<ApplierSyncReplication> replication;
public ApplierSyncReplication replication;

@InstanceDependency
public ApplierCommandDispatcher dispatcher;
Expand Down Expand Up @@ -153,7 +153,7 @@ public DefaultApplierServer(String clusterName, ClusterId clusterId, ShardId sha
Long qpsThreshold, Long bytesPerSecondThreshold, Long memoryThreshold, Long concurrencyThreshold, String subenv) throws Exception {
this.sequenceController = new DefaultSequenceController(qpsThreshold, bytesPerSecondThreshold, memoryThreshold, concurrencyThreshold);
this.dispatcher = new DefaultCommandDispatcher();
this.replication = new AtomicReference<>();
this.replication = new DefaultPsyncReplication(this);
this.offsetRecorder = new AtomicLong(-1);
this.replId = new AtomicReference<>("?");

Expand Down Expand Up @@ -247,44 +247,15 @@ public ApplierInstanceMeta getApplierInstanceMeta() {

@Override
public void setStateActive(Endpoint endpoint, GtidSet gtidSet, boolean useXsync) {
createReplication(useXsync);
this.state = STATE.ACTIVE;
replication.get().connect(endpoint, gtidSet);
}

private void createReplication(boolean useXsync) {
if (Objects.nonNull(replication.get())) {
if ((replication.get() instanceof DefaultXsyncReplication) != useXsync) {
throw new IllegalStateException("can't change protocol");
}
return;
}
logger.info("[setStateActive] useXsync:{}", useXsync);
try {
AbstractSyncReplication syncReplication;
if (useXsync) {
syncReplication = new DefaultXsyncReplication(this);
} else {
syncReplication = new DefaultPsyncReplication(this);
}
syncReplication.inject(dependencies);
ComponentRegistryHolder.getComponentRegistry().add(syncReplication);
this.replication.set(syncReplication);
} catch (Exception e) {
logger.error("[setStateActive] inject syncReplication error", e);
throw new RuntimeException("create replication error");
}

replication.connect(endpoint, gtidSet);
}


@Override
public void setStateBackup() {
if (Objects.isNull(replication)) {
createReplication(true);
}
this.state = STATE.BACKUP;
replication.get().connect(null);
replication.connect(null);
}

@Override
Expand All @@ -309,7 +280,7 @@ public STATE getState() {

@Override
public Endpoint getUpstreamEndpoint() {
return replication.get().endpoint();
return replication.endpoint();
}

@Override
Expand Down
Loading