Statistics #65
Merged
Statistics #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed empty line
removed empty line
liptons333
previously approved these changes
Sep 7, 2018
olegvm
reviewed
Sep 7, 2018
src/main/webapp/app/js/commons.js
Outdated
| } | ||
| } | ||
| var obj = "<table>" + |
There was a problem hiding this comment.
Should have a clearer name, such as statisticsTable.
olegvm
reviewed
Sep 7, 2018
|
|
||
| @Test | ||
| @DisplayName("test setStatusAchieved: throws ValidationException wrong user") | ||
| void testSetStatusAchievedThrowsExceptionIfWrongUser() { |
There was a problem hiding this comment.
For such long names, underscores can be used to separate parts of names:
testSetStatusAchieved_ThrowsExceptionIfWrongUser
I.e. "test" + method name that is being tested + underscore + extra part (+ underscore + more parts...).
There was a problem hiding this comment.
ok. will remember should i do it now?
There was a problem hiding this comment.
Yes, better do it, should be quick to do.
liptons333
approved these changes
Sep 7, 2018
olegvm
reviewed
Sep 7, 2018
|
|
||
| @Test | ||
| @DisplayName("test setStatusAchieved: changes status") | ||
| void test_SetStatusAchieved() { |
There was a problem hiding this comment.
No need to put the underscore right after "test" - testSetStatusAchieved is OK.
olegvm
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
mvn testfrom the root directory to see all new and existing tests passMotivation and Context
#63 #59
Description
just small final fixes, tests