Add dtype argument to define_constant #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test ensures that given two Float constants, where infers the output dtype properly.
|
Note that the complex examples in the test are commented as I am currently getting a |
The complex constant tests currently fail with a TypeError.
This fixes the issues I was having with defining complex constants. The problem was that the Python frontend actually generates Python code which gets evaluated, and that Python code was simply printing the values assuming they were real (if not bool). In the case of std::complex, C++ prints those as pairs i.e. a+b*j is printed as (a, b), which in Python is a tuple, not a complex value. Instead, we now print them as a+bj which is the compact form for a Python complex literal.
|
Fixed complex printing in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
dtypeargument todefine_constant. Internally, the data is held in the larger type: e.g. usingdefine_constant(3.5, dtype=DataType.Float)does not cast 3.5 to float, and does not affect the literal that is placed in the generated kernel. However, it does affect the type promotion rules for ops that determine the DataTypes of outputs. The added test demonstrates this behavior in where().Fixes #2380