Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPC] Specify circuit representation #57

Merged
merged 11 commits into from
Feb 7, 2024
Merged

[MPC] Specify circuit representation #57

merged 11 commits into from
Feb 7, 2024

Conversation

jschneider-bensch
Copy link
Contributor

This PR provides a circuit representation based on SINE's garble_lang project, but heavily simplified.

keks
keks suggested changes Feb 5, 2024
View reviewed changes
Copy link
Member

@keks keks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks really good! The feedback is mostly nitpicks to make iteration more consistent.

mpc-spec/src/circuit.rs Outdated Show resolved Hide resolved
mpc-spec/src/circuit.rs Outdated Show resolved Hide resolved
mpc-spec/src/circuit.rs Outdated Show resolved Hide resolved
mpc-spec/src/circuit.rs Outdated Show resolved Hide resolved
mpc-spec/src/circuit.rs Outdated Show resolved Hide resolved
keks
keks reviewed Feb 7, 2024
View reviewed changes
Copy link
Member

@keks keks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more nits.

Do you know if there is a code style guide for this project that says something about error messages? Otherwise I think it would be best to follow the convention laid out in the standard library.

mpc-spec/src/circuit.rs Outdated Show resolved Hide resolved
mpc-spec/src/circuit.rs Outdated Show resolved Hide resolved
mpc-spec/src/circuit.rs Outdated Show resolved Hide resolved
mpc-spec/src/circuit.rs Outdated Show resolved Hide resolved
mpc-spec/src/circuit.rs Outdated Show resolved Hide resolved
mpc-spec/src/circuit.rs Outdated Show resolved Hide resolved
keks
keks approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@keks keks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@jschneider-bensch jschneider-bensch merged commit f5fc95a into main Feb 7, 2024
3 checks passed
@jschneider-bensch jschneider-bensch deleted the jonas/mpc-spec branch February 7, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keks keks keks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschneider-bensch @keks