Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Workflow to build docs #29

Merged
merged 6 commits into from
Oct 6, 2023
Merged

Update Workflow to build docs #29

merged 6 commits into from
Oct 6, 2023

Conversation

jschneider-bensch
Copy link
Contributor

No description provided.

franziskuskiefer
franziskuskiefer approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with the two nits addressed

.github/workflows/docs.yml Outdated Show resolved Hide resolved
.github/workflows/docs.yml Outdated Show resolved Hide resolved
jschneider-bensch and others added 2 commits October 6, 2023 09:06
@jschneider-bensch @franziskuskiefer
Update .github/workflows/docs.yml
aae8f9e 
Remove conditional on `github.refs`

Co-authored-by: Franziskus Kiefer <[email protected]>
@jschneider-bensch
Update docs.yml
098982c 
More generic name for GH Pages workflow
@jschneider-bensch jschneider-bensch merged commit 9cbade8 into main Oct 6, 2023
3 checks passed
@jschneider-bensch jschneider-bensch deleted the jonas/ci-docs branch October 6, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschneider-bensch @franziskuskiefer