Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: color management #2

Merged
merged 2 commits into from
Dec 28, 2024
Merged

fix: color management #2

merged 2 commits into from
Dec 28, 2024

Conversation

hyochan
Copy link
Member

@hyochan hyochan commented Dec 28, 2024

Description

Major Update:
• Enhanced the color system for easier updates.
• Updated stories to reflect how changes to existing color variables are applied to components.

Bug Fix:
• Resolved an issue where button loading colors were not being properly injected.

Test Plan

See included stories in Button and Typography with Custom prefix.

Tests

N/A

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn test:all and make sure nothing fails.
  • I am willing to follow-up on review comments in a timely manner.

@hyochan hyochan added ፦ refactor 🛠 bugfix All kinds of bug fixes labels Dec 28, 2024
Copy link

Visit the preview URL for this PR (updated for commit 00deb70):

https://cpk-ui--pr2-fix-theme-manager-pihvucht.web.app

(expires Sat, 04 Jan 2025 06:08:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 05244aa8e2a82af676f8a528c78a4bcd59756f99

@hyochan hyochan merged commit 09bbf1f into main Dec 28, 2024
3 checks passed
@hyochan hyochan deleted the fix/theme-manager branch December 28, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 bugfix All kinds of bug fixes ፦ refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant