Fix the update loop in Firewall.networkfirewall resource #1167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Related PR: upbound/official-providers-ci#180
This PR fixes an update loop issue in the
Firewall.networkfirewall
resource and extends the example manifest for the that resource with thefirewallPolicyChangeProtection
&subnetChangeProtection
parameters, and enables the update tests on it.This PR also bumps uptest to
v0.11.1
to properly run the update test on theFirewall.networkfirewall
resource.I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Via an uptest run with the update-test step: https://github.com/upbound/provider-aws/actions/runs/8065145812