Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the update loop in Firewall.networkfirewall resource #1167

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Feb 21, 2024

Description of your changes

Related PR: upbound/official-providers-ci#180

This PR fixes an update loop issue in the Firewall.networkfirewall resource and extends the example manifest for the that resource with the firewallPolicyChangeProtection & subnetChangeProtection parameters, and enables the update tests on it.

This PR also bumps uptest to v0.11.1 to properly run the update test on the Firewall.networkfirewall resource.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Via an uptest run with the update-test step: https://github.com/upbound/provider-aws/actions/runs/8065145812

- Extend the example manifest for the Firewall.networkfirewall
  resource with some extra parameters and enable the update tests
  on it.

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
(cherry picked from commit e8b5f1a)
@ulucinar
Copy link
Collaborator Author

/test-examples="examples/networkfirewall/v1beta1/firewall.yaml"

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@ulucinar
Copy link
Collaborator Author

/test-examples="examples/networkfirewall/v1beta1/firewall.yaml"

examples/networkfirewall/v1beta1/firewall.yaml.

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
@ulucinar
Copy link
Collaborator Author

/test-examples="examples/networkfirewall/v1beta1/firewall.yaml"

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar
Copy link
Collaborator Author

A local run of make lint has succeeded. Merging the PR...

@ulucinar ulucinar merged commit cbef5d5 into crossplane-contrib:main Feb 28, 2024
9 of 10 checks passed
@ulucinar ulucinar deleted the fix-firewall-update branch February 28, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants