Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add computation of previous and next certificate versions based on ID. #459

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

J08nY
Copy link
Member

@J08nY J08nY commented Nov 20, 2024

Fixes #457.

@J08nY J08nY added enhancement New feature or request cc Related to CC certification labels Nov 20, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 18 lines in your changes missing coverage. Please review.

Project coverage is 67.74%. Comparing base (52e5851) to head (d2a5644).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/sec_certs/sample/cc.py 48.58% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
- Coverage   68.54%   67.74%   -0.79%     
==========================================
  Files          62       62              
  Lines        7900     7934      +34     
==========================================
- Hits         5414     5374      -40     
- Misses       2486     2560      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@J08nY J08nY merged commit 6da6641 into main Nov 21, 2024
6 checks passed
@J08nY J08nY deleted the feat/certificate-versions branch November 21, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cc Related to CC certification enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add certificate version heuristic based on ID version
1 participant