-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: idp cert fingerprint and actual idp cert #551
Open
svennjegac
wants to merge
1
commit into
crewjam:main
Choose a base branch
from
svennjegac:feat/idp-cert-fp-and-actual-cert
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firstly, thank you for this PR. This functionality is something I also want from this package!
Just a thought, maybe the type here should just be a
x509.Certificate
and the consumer should be responsible for parsing their certificate themselves.The reason I suggest this is that it's not certain that everyone is going to be using base64-encoded ASN.1 DER strings for their certificates (which it appears from
parseCert
yours does).In my case, my (legacy) application simply has them encoded as PEM strings like so:
-----BEGIN CERTIFICATE-----\r\nABCEDFG\r\n-----END CERTIFICATE-----
, so to use your PR I would likely need to usepem.Decode
, then base-64 encode the string, just to provide it to this package, which then base64-decodes it again.I think this change would make it more reusable.