merge: develop to QA #576
Closed
merge: develop to QA #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: karan <[email protected]>
…-session-management
fix: user session management
Signed-off-by: karan <[email protected]>
fix: passkey alignment
Signed-off-by: karan <[email protected]>
fix: pagination on history page
vivekayanworks
suggested changes
Feb 12, 2024
| @@ -38,7 +38,11 @@ const PasskeyAddDevice = (props: { | |||
| if (data?.statusCode === apiStatusCodes.API_STATUS_SUCCESS) { | |||
| setNextFlag(true) | |||
| } else { | |||
| setFidoUserError(passkeyUserDetailsResp as string) | |||
| if (passkeyUserDetailsResp.toString().includes('401')) { | |||
There was a problem hiding this comment.
This if can be shifted along ith else statement as this if does not have any else part.
Signed-off-by: karan <[email protected]>
Signed-off-by: karan <[email protected]>
Signed-off-by: karan <[email protected]>
fix: minor bugs fixes and performance optimisation
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why