Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: externalize env #153

Merged
merged 10 commits into from
Jul 17, 2024
Merged

feat: externalize env #153

merged 10 commits into from
Jul 17, 2024

Conversation

GHkrishna
Copy link
Contributor

What

  • externalise ENV

Why

  • avoid hardcoded values

GHkrishna added 7 commits July 17, 2024 15:04
@GHkrishna
fix: externalise env
a94623e 
Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna
fix: externalise env
16dbd01 
Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna
fix: number conversion
0a3e30e 
Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna
fix: remove logs
45f292a 
Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna
fix: sample env variable
5d884af 
Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna
fix: remove comments
c32c5f3 
Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna
fix: remove comments
66e6205 
Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna GHkrishna added the enhancement New feature or request label Jul 17, 2024
@GHkrishna GHkrishna self-assigned this Jul 17, 2024
@GHkrishna
chore: github warnings
b4f327f 
Signed-off-by: Krishna Waske <[email protected]>
@sairanjit
Copy link
Contributor

@GHkrishna Can you run yarn format and fix the prettier issues?

@GHkrishna
chore: fix preetier
5c940ac 
Signed-off-by: Krishna Waske <[email protected]>
@GHkrishna
Copy link
Contributor Author

@GHkrishna Can you run yarn format and fix the prettier issues?

Done

@GHkrishna
chore: fix preetier
74ff02c 
Signed-off-by: Krishna Waske <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sairanjit
sairanjit approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@sairanjit sairanjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sairanjit sairanjit merged commit 2c8f63b into main Jul 17, 2024
5 checks passed
@sairanjit sairanjit deleted the feat/externalize-env branch July 17, 2024 13:33
@GHkrishna GHkrishna restored the feat/externalize-env branch August 1, 2024 07:48
GHkrishna added a commit that referenced this pull request Sep 11, 2024
@GHkrishna
feat: externalize env (#153)
0901772 
Signed-off-by: Krishna Waske <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 13, 2024
@GHkrishna
feat: externalize env (#153)
c710479 
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 13, 2024
@GHkrishna
feat: externalize env (#153)
b1a867b 
Signed-off-by: KulkarniShashank <[email protected]>
GHkrishna added a commit that referenced this pull request Sep 13, 2024
@GHkrishna
feat: externalize env (#153)
e39fe7d 
Signed-off-by: Krishna Waske <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sairanjit sairanjit sairanjit approved these changes

@ankita-p17 ankita-p17 Awaiting requested review from ankita-p17

Assignees

@GHkrishna GHkrishna

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GHkrishna @sairanjit