Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap preprocess_and_plan function in a class #141

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Wrap preprocess_and_plan function in a class #141

merged 1 commit into from
Nov 7, 2023

Conversation

HangJung97
Copy link
Member

@HangJung97 HangJung97 commented Nov 7, 2023 •
edited
Loading

What does this PR do?

Wrap preprocess_and_plan function in a class

  • To make sure that the configs defined in ASCENT/configs are discoverable when calling preprocess_and_plan from a project that uses ASCENT as a submodule

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@HangJung97
Wrap preprocess_and_plan function in a class
3df6c1d 
- To make the configs to be discoverable when calling `preprocess_and_plan` from a project that uses ASCENT as a submodule
@HangJung97 HangJung97 added the enhancement New feature or request label Nov 7, 2023
@HangJung97 HangJung97 self-assigned this Nov 7, 2023
@HangJung97 HangJung97 merged commit bd54c50 into main Nov 7, 2023
1 check passed
@HangJung97 HangJung97 deleted the feature/preprocessing branch November 7, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@HangJung97 HangJung97

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HangJung97