Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add community IDs for boards managed by ddrown #80

Merged
merged 2 commits into from
Dec 16, 2024
Merged

add community IDs for boards managed by ddrown #80

merged 2 commits into from
Dec 16, 2024

Conversation

ddrown
Copy link
Contributor

@ddrown ddrown commented Dec 9, 2024 •
edited
Loading

@ddrown ddrown mentioned this pull request Dec 9, 2024
Open
ddrown added a commit to ddrown/circuitpython that referenced this pull request Dec 9, 2024
@ddrown
use IDs from creationid/creators#80
2238e64
tannewt
tannewt requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to manage some ids for yourself, I'd suggest linking to a separate repo that you manage. If you want to make an Elecrow community list, then this is a good place. Either one is ok with me. (I wouldn't do a list for yourself here.)

@ddrown
Copy link
Contributor Author

ddrown commented Dec 13, 2024

Looks like Elecrow doesn't have a VID as far as I can tell, so I'll go with managing the devices out of a repo published to github pages.

tannewt
tannewt approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 8972546 into creationid:main Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddrown @tannewt