Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid waiting forever on API response #4519

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

albfan
Copy link
Contributor

@albfan albfan commented Dec 17, 2024

Set a default timeout of 30s to avoid crc to hang on commands waiting on API response

Fixes: #4518

@openshift-ci openshift-ci bot requested review from cfergeau and evidolob December 17, 2024 12:27
Copy link

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gbraad for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@albfan albfan requested review from anjannath and removed request for cfergeau and evidolob December 17, 2024 12:27
Copy link

openshift-ci bot commented Dec 17, 2024

@albfan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security ae2c16d link false /test security
ci/prow/integration-crc ae2c16d link true /test integration-crc
ci/prow/images ae2c16d link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@anjannath
Copy link
Member

anjannath commented Dec 19, 2024

Set a default timeout of 30s to avoid crc to hang on commands waiting on API response

could you please add this PR description to the commit description as well

and the CI jobs are failing with the error:

pkg/crc/daemonclient/client.go:28: File is not `gofmt`-ed with `-s` (gofmt)
			Timeout: 30 * time.Second,
make: *** [Makefile:265: cross-lint] Error 1

could you please run make fmt and re push!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crc getting stuck on API
2 participants