Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore : Update pull request template to remove link giving 404 #4516

Conversation

rohanKanojia
Copy link
Contributor

Description

I received some feedback from @lilyLuLiu regarding pull request template. Hence making some changes to accomodate these points

Relates to: #4488

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Proposed changes

  • Development guide link got moved and was giving 404. However, having link to development guide doesn't help much at the time of creating the pull request. A contributor would be reading development guide only during the initial onboarding. It's not relevent to include it in pull request template in PR checklist.
  • Changed the wording of sentence where PR author provides information about the platforms tested with the specified changes.

Testing

Not Applicable

Contribution Checklist

  • I have read the contributing guidelines
  • My code follows the style guidelines of this project
  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I tested my code on specified platforms
    • Linux
    • Windows
    • MacOS

I received some feedback from @lilyLuLiu regarding pull request
template. Hence making some changes to accomodate these points:
- Development guide link got moved and was giving 404. However, having
  link to development guide doesn't help much at the time of creating
  the pull request. A contributor would be reading development guide
  only during the initial onboarding. It's not relevent to include it in
  pull request template in PR checklist.
- Changed the wording of sentence where PR author provides information
  about the platforms tested with the specified changes.

Signed-off-by: Rohan Kumar <[email protected]>
Copy link

openshift-ci bot commented Dec 17, 2024

@rohanKanojia: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc 1093239 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rohanKanojia rohanKanojia self-assigned this Dec 17, 2024
Copy link

openshift-ci bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lilyLuLiu
Once this PR has been reviewed and has the lgtm label, please assign evidolob for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@praveenkumar praveenkumar merged commit e119f1c into crc-org:main Dec 23, 2024
22 of 35 checks passed
@rohanKanojia rohanKanojia deleted the pr/pull_request_template_remove_broken_link branch December 23, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants