deprecated preset: add warning for podman preset during and commands #4012
Conversation
|
Skipping CI for Draft Pull Request. |
| @@ -22,6 +22,11 @@ var presetMap = map[Preset]string{ | |||
| Microshift: string(Microshift), | |||
| } | |||
|
|
|||
| const ( | |||
| PodmanDeprecatedWarning = "The Podman preset is deprecated and will be removed in a future release. Consider" + | |||
| " rather using a Podman Machine managed by Podman Desktop: https://podman-desktop.io" | |||
There was a problem hiding this comment.
👍, @themr0c will appreciate this.
There was a problem hiding this comment.
thanks, I hope so as I took the words from him 😄
There was a problem hiding this comment.
/me knows. I approved those ;-)
| @@ -87,6 +87,10 @@ func runStart(ctx context.Context) (*types.StartResult, error) { | |||
| EnableBundleQuayFallback: config.Get(crcConfig.EnableBundleQuayFallback).AsBool(), | |||
| } | |||
|
|
|||
| if startConfig.Preset == preset.Podman { | |||
| logging.Warn(preset.PodmanDeprecatedWarning) | |||
vyasgun
force-pushed
the
pr/deprecated-preset
branch
from
17c8bf0 to
6c1f377
Compare
|
@vyasgun: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/ltgm note: ouch, mouse slipped over the button and pressed wrong. |
|
/lgtm |
|
|
||
| if key == Preset && value == string(preset.Podman) { | ||
| logging.Warn(preset.PodmanDeprecatedWarning) | ||
| } |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gbraad, praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: Issue #3970
Solution/Idea
podmanpreset deprecation warning has been added in two places:crc config set preset podmanandcrc startProposed changes
Testing
What is the bottom-line functionality that needs testing? Describe in pseudo-code or in English. Use verifiable statements that tie your changes to existing functionality.
crc config set preset podmanshould print a warningcrc startwith already set presetpodmanshould print a warning