Validation: Don't fail if the bundle path is same as default path #3826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfergeau
reviewed
Sep 7, 2023
|
/retest |
praveenkumar
force-pushed
the
validation_fixes
branch
from
87ea34a to
b541736
Compare
|
@praveenkumar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
ValidateBundle function try to get the bundle info if the bundle is already extracted or run ValidateBundlePath which in case check if the bundle exist for provided path and for default bundle it give error in case not persent in the default location. Ideally ValidateBundle should just return nil in case default bundle path is provided. With this change, same function can consme as part of `cmd/setup` which right now have addition logic to ignore default bundle path.
In previous commit 5fbcac2 , ValidateBundle now handle the default bundlepath also so we shouldn't have a different logic here.
This logic we have in `fixBundleExtract` function is kind of unnecessary because ValidationBundle already part of setup,start and config set command so having same logic doesn't make sense.
invalidPath type only used in the validation so no point to make it public.
With this PR now end user will observe more meaningful message to run `crc setup` in case want to use the default bundle. ``` $ ./crc config set bundle /foo/bar Value '/foo/bar' for configuration property 'bundle' is invalid, reason: /foo/bar is invalid or missing, run 'crc setup' to download the default bundle $ ./crc start -b /foo/bar /foo/bar is invalid or missing, run 'crc setup' to download the default bundle ```
praveenkumar
force-pushed
the
validation_fixes
branch
from
b541736 to
5aa9365
Compare
cfergeau
approved these changes
Sep 29, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValidateBundle function try to get the bundle info if the bundle is
already extracted or run ValidateBundlePath which in case check if the
bundle exist for provided path and for default bundle it give error in
case not persent in the default location. Ideally ValidateBundle should
just return nil in case default bundle path is provided.
With this change, same function can consme as part of
cmd/setupwhichright now have addition logic to ignore default bundle path.