Add persistent volume size option to config #3820

praveenkumar · 2023-09-05T04:41:00Z

This pr enable user to specify the size which is used by persistent volume in case of microshift preset. As of now we just extend the disk size to root mounted partition and free space (which used for pvc) is only 15GiB. Some users want to have more free space to consume it for pvc as per the workload and with this option now it is possible.

$ crc config set disk-size 50
$ crc config set persistent-volume-size 20
$ crc start
[...]
<crc_vm> $ sudo vgdisplay
  --- Volume group ---
  VG Name               rhel
  System ID
  Format                lvm2
  Metadata Areas        1
  Metadata Sequence No  5
  VG Access             read/write
  VG Status             resizable
  MAX LV                0
  Cur LV                1
  Open LV               1
  Max PV                0
  Cur PV                1
  Act PV                1
  VG Size               <49.02 GiB
  PE Size               4.00 MiB
  Total PE              12549
  Alloc PE / Size       7429 / <29.02 GiB
  Free  PE / Size       5120 / 20.00 GiB
  VG UUID               O7d5v9-F8HE-E0Dj-e9sE-1qgv-F74d-CZz34d

Fixes: Issue #3747

jsliacan · 2023-09-05T07:25:32Z

So PVC size comes out of the disk size, right? I.e. 0GiB <= pvc size <= disk size - 15GiB? I'm assuming that the last inequality is actually strict to leave space for other things. What would be the maximum possible pvc size for a fixed disk size?

gbraad · 2023-09-18T05:51:17Z

pkg/crc/machine/start.go

-	// vgFree space as part of the bundle is default to ~15.02G (16127098880 byte)
-	vgFree := 16127098880
+	// 1GB = 1073741824 bytes
+	vgFree := persistentVolumeSize * 1073741824


GB := 107374... // bytes vgFree := persistentVolumeSize * GB

which makes things s stand out more clearly than the comment

gbraad · 2023-09-18T05:53:11Z

pkg/crc/config/settings.go

@@ -91,6 +92,8 @@ func RegisterSettings(cfg *Config) {
 		"Enable experimental features (true/false, default: false)")
 	cfg.AddSetting(EmergencyLogin, false, ValidateBool, SuccessfullyApplied,
 		"Enable emergency login for 'core' user. Password is randomly generated. (true/false, default: false)")
+	cfg.AddSetting(PersistentVolumeSize, constants.DefaultPersistentVolumeSize, validatePersistentDiskSize, SuccessfullyApplied,
+		fmt.Sprintf("Total size in GiB of the persistent volume (must be greater than or equal to '%d')", constants.DefaultPersistentVolumeSize))


used for what?
it misses explanation as containers arent stored here

I am going to use https://github.com/openshift/microshift/blob/main/docs/contributor/rhel4edge_iso.md#disk-partitioning same explanation Unallocated disk space of 9GB size remains in the rhel volume group to be used by the CSI driver.

gbraad · 2023-09-18T05:55:27Z

@jsliacan I had the same question just now pop up. also, what is the usage as that isnt explained to the user. ephemeral and persistent have clear usecases,...

praveenkumar · 2023-09-21T09:04:55Z

So PVC size comes out of the disk size, right? I.e. 15GiB <= pvc size <= disk size? I'm assuming that the last inequality is actually strict to leave space for other things. What would be the maximum possible pvc size for a fixed disk size?

@jsliacan As of now maximum pvc size user can allocate <Total Disk Size> - 15G so if user put 40GB as disk size then he can use ~ 25G for pvc.

pkg/crc/validation/validation.go

pkg/crc/config/settings.go

pkg/crc/validation/validation.go

pkg/crc/config/validations.go

This pr enable user to specify the size which is used by persistent volume in case of microshift preset. As of now we just extend the disk size to root mounted partition and free space (which used for pvc) is only 15GiB. Some users want to have more free space to consume it for pvc as per the workload and with this option now it is possible. ``` $ crc config set disk-size 50 $ crc config set persistent-volume-size 20 $ crc start [...] <crc_vm> $ sudo vgdisplay --- Volume group --- VG Name rhel System ID Format lvm2 Metadata Areas 1 Metadata Sequence No 5 VG Access read/write VG Status resizable MAX LV 0 Cur LV 1 Open LV 1 Max PV 0 Cur PV 1 Act PV 1 VG Size <49.02 GiB PE Size 4.00 MiB Total PE 12549 Alloc PE / Size 7429 / <29.02 GiB Free PE / Size 5120 / 20.00 GiB VG UUID O7d5v9-F8HE-E0Dj-e9sE-1qgv-F74d-CZz34d ```

anjannath

LGTM

anjannath · 2023-09-27T06:38:27Z

pkg/crc/config/settings.go

@@ -91,6 +92,8 @@ func RegisterSettings(cfg *Config) {
 		"Enable experimental features (true/false, default: false)")
 	cfg.AddSetting(EmergencyLogin, false, ValidateBool, SuccessfullyApplied,
 		"Enable emergency login for 'core' user. Password is randomly generated. (true/false, default: false)")
+	cfg.AddSetting(PersistentVolumeSize, constants.DefaultPersistentVolumeSize, validatePersistentVolumeSize, SuccessfullyApplied,
+		fmt.Sprintf("Total size in GiB of the persistent volume used by the CSI driver for %s preset (must be greater than or equal to '%d')", preset.Microshift, constants.DefaultPersistentVolumeSize))


ahh, sorry i forgot to mention this earlier, maybe we should use preset.Microshift.ForDisplay() here

@anjannath since preset have string method %s should able to get preset and Display is for end user display I think here they should know the preset value instead of Display?

openshift-ci · 2023-09-27T06:38:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anjannath

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [anjannath]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2023-09-27T07:35:34Z

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-crc	`306fbb6`	link	true	`/test e2e-crc`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci bot requested review from anjannath and evidolob September 5, 2023 04:41

gbraad reviewed Sep 18, 2023

View reviewed changes

praveenkumar force-pushed the issue_3747 branch from 943c6aa to f43c6e7 Compare September 22, 2023 09:35

anjannath reviewed Sep 25, 2023

View reviewed changes

pkg/crc/validation/validation.go Outdated Show resolved Hide resolved

anjannath reviewed Sep 25, 2023

View reviewed changes

pkg/crc/config/settings.go Outdated Show resolved Hide resolved

praveenkumar force-pushed the issue_3747 branch from f43c6e7 to 0e332e6 Compare September 26, 2023 08:07

anjannath reviewed Sep 26, 2023

View reviewed changes

pkg/crc/validation/validation.go Outdated Show resolved Hide resolved

anjannath reviewed Sep 26, 2023

View reviewed changes

pkg/crc/config/validations.go Outdated Show resolved Hide resolved

praveenkumar self-assigned this Sep 26, 2023

praveenkumar force-pushed the issue_3747 branch from 0e332e6 to 306fbb6 Compare September 27, 2023 05:08

anjannath approved these changes Sep 27, 2023

View reviewed changes

openshift-ci bot assigned anjannath Sep 27, 2023

openshift-ci bot added the lgtm label Sep 27, 2023

openshift-ci bot added the approved label Sep 27, 2023

praveenkumar merged commit d745575 into crc-org:main Sep 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add persistent volume size option to config #3820

Add persistent volume size option to config #3820

praveenkumar commented Sep 5, 2023

jsliacan commented Sep 5, 2023 •

edited

Loading

gbraad Sep 18, 2023 •

edited

Loading

gbraad Sep 18, 2023

praveenkumar Sep 21, 2023 •

edited

Loading

gbraad commented Sep 18, 2023

praveenkumar commented Sep 21, 2023

anjannath left a comment

anjannath Sep 27, 2023

praveenkumar Sep 28, 2023

openshift-ci bot commented Sep 27, 2023

openshift-ci bot commented Sep 27, 2023

Add persistent volume size option to config #3820

Add persistent volume size option to config #3820

Conversation

praveenkumar commented Sep 5, 2023

jsliacan commented Sep 5, 2023 • edited Loading

gbraad Sep 18, 2023 • edited Loading

Choose a reason for hiding this comment

gbraad Sep 18, 2023

Choose a reason for hiding this comment

praveenkumar Sep 21, 2023 • edited Loading

Choose a reason for hiding this comment

gbraad commented Sep 18, 2023

praveenkumar commented Sep 21, 2023

anjannath left a comment

Choose a reason for hiding this comment

anjannath Sep 27, 2023

Choose a reason for hiding this comment

praveenkumar Sep 28, 2023

Choose a reason for hiding this comment

openshift-ci bot commented Sep 27, 2023

openshift-ci bot commented Sep 27, 2023

jsliacan commented Sep 5, 2023 •

edited

Loading

gbraad Sep 18, 2023 •

edited

Loading

praveenkumar Sep 21, 2023 •

edited

Loading