add bindings to generate proof from uncompressed banderwagon values #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tanishqjasoria
commented
Aug 13, 2024
•
tanishqjasoria
commented
- add c bindings package
- add functions to generate and verify proof from uncompressed banderwagon values
Added verify_proof function to be called from C# bandersnatch repository
…d 64 bytes commitment into 32 bytes - Called in new function deserialize_proof_query_uncompressed
…ment in prover queries bytes
Bindings Update with latest rust changes
tanishqjasoria
force-pushed
the
bindings
branch
from
16a4815 to
ee3121b
Compare
|
Would be good, if you could add a dummy C sharp project, so that we can merge and keep pushing releases to it! |
kevaundray
reviewed
Aug 15, 2024
kevaundray
reviewed
Aug 15, 2024
kevaundray
reviewed
Aug 27, 2024
kevaundray
approved these changes
Aug 27, 2024
kevaundray
reviewed
Aug 27, 2024
Comment on lines
+214
to
+220
| pub fn to_bytes_uncompressed(&self) -> crate::IOResult<Vec<u8>> { | ||
| let mut bytes = Vec::with_capacity(self.open_proof.uncompressed_size() + 64); | ||
| bytes.extend(self.g_x_comm.to_bytes_uncompressed()); | ||
|
|
||
| bytes.extend(self.open_proof.to_bytes_uncompressed()?); | ||
| Ok(bytes) | ||
| } |
There was a problem hiding this comment.
I'll clean up serialization in another PR, its becoming a bit unwieldly because its not opaque :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.