Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding docs about using pyproject.toml #834

Closed
wants to merge 2 commits into from
Closed

adding docs about using pyproject.toml #834

wants to merge 2 commits into from

Conversation

Borda
Copy link

@Borda Borda commented Sep 26, 2023

Adding note about using pyproject.toml which was added recently:
ref:

@Borda
Copy link
Author

Borda commented Sep 26, 2023

@epage mind have look and approve CI run, pls 🐰

Comment on lines +106 to 122
### Supported config files

The default option is setting the configuration in `typos.toml`, `_typos.toml` or `.typos.toml`.

In addition, you can set the same configuration with standard python's config file `pyproject.toml` by adding `[tool.typos.xyz]` where the `xyz` is the same as in default `_typos.toml` so the sample configuration above will be:
```toml
[tool.typos.default]
extend-ignore-identifiers-re = ["AttributeID.*Supress.*"]

[tool.typos.default.extend-identifiers]
AttributeIDSupressMenu = "AttributeIDSupressMenu"

[tool.typos.default.extend-words]
teh = "teh"
```

### Integrations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this was covered in #826. If we want to expand it, we should probably do it in that area within the context of whats there

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may suggest to have it readme as it is easy to find and the other location was not discoverable =( so I found it based on issue and merged PR...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README is focused on being a quick start, delegating to this file for the details.

Copy link
Author

@Borda Borda Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but for some cases like us, the need to add a new config in the root could be a deal breaker so in such cases, we cannot use it... so how about making it lighter #834 (comment)?

README.md Show resolved Hide resolved
@epage
Copy link
Collaborator

epage commented Sep 26, 2023

This is not aligning with the goal of this section of the documentation. This is a getting started and isn't meant to cover every feature people might need to use.

@epage epage closed this Sep 26, 2023
@Borda
Copy link
Author

Borda commented Sep 26, 2023

This is not aligning with the goal of this section of the documentation. This is a getting started and isn't meant to cover every feature people might need to use.

do you call configuration any feature? :)

never mined, just wanted to help; but you call and approach in the end, good luck :)

@Borda Borda deleted the docs/pyproject branch September 26, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants