Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print is async(). In Firefox, cleanUp was resulting in a blank print preview page. … #538

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scottgroovez
Copy link

…This small delay fixes it.

@coveralls
Copy link

coveralls commented Feb 16, 2021

Pull Request Test Coverage Report for Build 338

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 48.241%

Totals Coverage Status
Change from base Build 328: 0.0%
Covered Lines: 239
Relevant Lines: 363

💛 - Coveralls

@FelixSchwarz
Copy link

Just a comment from a complete outsider and maybe just personal preference but I think it would be good to add a comment in the code (basically the same as the PR description). That way it is way easier to understand why the delay is present even without using git blame or github.

@abdullah-tahir-exodevs
Copy link

hi ... I am just commenting for this purpose that The issue which is coming in the Firefox, the file is previewing with the blank page in the Firefox browser How much time it take to resolve the issue

@abdullah-tahir-exodevs
Copy link

hi ... I am just commenting for this purpose that The issue which is coming in the Firefox, the file is previewing with the blank page in the Firefox browser How much time it take to resolve the issue

this pull request is not working . I tried it in my project but is not working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants