[Pedometer] add Pedometer.stepStream #701
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently pedometer only provides one stream for changes in the pedestrian status and one for changes is the step count.
This PR add another stream that yields every time a step is detected. It uses the step detection event channel which is already used by the pedestrian status stream but does not filter the events.
I've tested in on Android and it works. Unfortunately I have no way to test it on ios, but as the event channel on ios seems to return the pedestrian status directly, I assume it will only yield on pedestrian status change and will therefor not work as expected.