Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps(v7)!: bump IBC-Go v7.6.0 #199

Closed
wants to merge 5 commits into from
Closed

deps(v7)!: bump IBC-Go v7.6.0 #199

wants to merge 5 commits into from

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Jun 20, 2024 •
edited
Loading

Will tag as packet-forward-middleware v7.2.0

@github-actions github-actions bot added packet-forward-middleware Label for items related to the packet forward middleware async-icq Label for items related to the async-icq module labels Jun 20, 2024
@Reecepbcups Reecepbcups changed the title deps(v7): bump IBC-Go v7.6.0 deps(v7)!: bump IBC-Go v7.6.0 Jun 20, 2024
@Reecepbcups
Copy link
Member Author

i think something with the golangci-lint server is down. Works for me locally, not remote (404) on download.

@Reecepbcups Reecepbcups marked this pull request as ready for review June 20, 2024 14:09
@Reecepbcups Reecepbcups requested review from jtieri and agouin and removed request for jtieri June 20, 2024 14:09
@jtieri
Copy link
Member

jtieri commented Jun 26, 2024

i think something with the golangci-lint server is down. Works for me locally, not remote (404) on download.

so weird it looks like it is still returning some errors. i didn't deep dive this but it almost looks like the things it is complaining about aren't even issues in this repo though but rather one of the dependencies?

@Reecepbcups
Copy link
Member Author

@jtieri yep exactly! It may be due to some go1.XX version thing or linter version based on one of the deps.

@jtieri
Copy link
Member

jtieri commented Jul 5, 2024

@jtieri yep exactly! It may be due to some go1.XX version thing or linter version based on one of the deps.

what should we do with this, just approve and merge?

@Reecepbcups
Copy link
Member Author

@jtieri yea I think so. Nothing blocking on our end, passes locally for me so linting is not an issue

@jtieri jtieri mentioned this pull request Aug 6, 2024
Merged
@Reecepbcups
Copy link
Member Author

closing, do in the new v7 backport PR

@Reecepbcups Reecepbcups closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agouin agouin Awaiting requested review from agouin

@jtieri jtieri Awaiting requested review from jtieri

Assignees
No one assigned
Labels
async-icq Label for items related to the async-icq module packet-forward-middleware Label for items related to the packet forward middleware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Reecepbcups @jtieri