Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(deps): Upgrade PFM to IBC v8 and SDK v0.50.x #152

Merged
merged 27 commits into from
Jan 5, 2024
Merged

core(deps): Upgrade PFM to IBC v8 and SDK v0.50.x #152

merged 27 commits into from
Jan 5, 2024

Conversation

alexanderbez
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the packet-forward-middleware Label for items related to the packet forward middleware label Dec 22, 2023
@alexanderbez alexanderbez changed the title core(deps): Upgrade Packet Forward Middleware to IBC v8 and SDK v0.50.x core(deps): Upgrade PFM to IBC v8 and SDK v0.50.x Dec 23, 2023
@faddat
Copy link
Contributor

faddat commented Dec 24, 2023

thank you

This was referenced Dec 24, 2023
Closed
Open
@alexanderbez
Copy link
Contributor Author

Got the build to pass...let's see how tests go.

@alexanderbez
Copy link
Contributor Author

@faddat or anyone else, I've pretty much updated everything that needs to be updated. The E2E tests are still failing, currently with:

Error: error creating clients: failed to create client on src chain{chain-a}: client identifier event attribute not found
        	Test:       	TestTimeoutOnForward

I think it's at the point where it requires someone a bit more acquainted with PFM to put the finishing touches on this to get this over the finish line.

@faddat
Copy link
Contributor

faddat commented Dec 27, 2023

I'll merge yours into mine, but felt rather the same way as you sir.

@alexanderbez
Copy link
Contributor Author

Thanks for pushing this over the finish line @Reecepbcups

@Reecepbcups Reecepbcups marked this pull request as ready for review January 5, 2024 01:34
@Reecepbcups
Copy link
Member

Thank you for your contributions here @alexanderbez 🫡

I'll tag v8.0.0 releases for Async-ICQ and PFM once the rest of the Strangelove team is back from winter break

@Reecepbcups Reecepbcups merged commit 76989c8 into main Jan 5, 2024
9 checks passed
@Reecepbcups Reecepbcups deleted the bez/update-pkt-fwrd-mw-v8 branch January 5, 2024 01:42
@rootulp rootulp mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reecepbcups Reecepbcups Reecepbcups approved these changes

Assignees
No one assigned
Labels
packet-forward-middleware Label for items related to the packet forward middleware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexanderbez @faddat @Reecepbcups