Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update async-icq to ibc-go/v8. #151

Merged
merged 43 commits into from
Jan 4, 2024
Merged

Update async-icq to ibc-go/v8. #151

merged 43 commits into from
Jan 4, 2024

Conversation

Taztingo
Copy link
Contributor

This updates async-icq to ibc-go/v8 as mentioned in #150.

@Taztingo
Start conversion to ibc-go/v8. Fix some dependencies.
03e13fd
@Taztingo
Fix capability imports.
85f18ee
@Taztingo
Removed handlers.
975dc97
@Taztingo
Change tmservice to cmtservice.
eca62fb
@Taztingo
Remove ibc client and router. Also remove upgrade from router.
6247e7f
@Taztingo
Start updating keepers and fixing errors.
3c19ae6
@Taztingo
Add missing methods needed by module.
c26a6b5
@Taztingo
Fix InitChainer and AppModules.
d5ff864
@Taztingo
Add PreBlocker.
888830d
@Taztingo
Remove unused methods in module.go
2c2be7b
@Taztingo
update logger and fix out of date functions in relayer.
c4dc26d
@Taztingo
Update migrations to be compatible with sdk v0.50.
dabebe1
@Taztingo
Update types to use ProtoCodec.
6c59d9c
@Taztingo
Remove legacy amino.
64e4bb4
@Taztingo
I think I properly updated that test?
ef366ab
@Taztingo
Update export.
339ac2d
@Taztingo
Fix remaining issues in app, encoding, and genesis.
23dd3f8
@Taztingo
Update filename in README.
5f0dd56
@Taztingo
Update root.go
1da64cb
@Taztingo
Fix upgrades.
b080c8e
@Taztingo
Fix dependencies so it can compile. Remove rosetta for now.
940f46e
@Taztingo
Add module basics back temporarily.
b281b17
@Taztingo
Remove ModuleBasics.
efc2f02
@Taztingo
Fix missing address encoders.
267779f
@Taztingo
Create new image for icq-host and delete old v7 verison.
2e3dc60
@Taztingo
Fix end to end test.
1971221
@Taztingo
Fix go.mod in e2e to tidy up. Fix v8 versioning at a later time.
94828c9
@Taztingo
Update upgrade_test for sdk 50.
ce61647
@Taztingo
Update workflow to use v8 tar.
b0d7060
@github-actions github-actions bot added the async-icq Label for items related to the async-icq module label Dec 21, 2023
This was referenced Dec 24, 2023
Closed
Open
@Taztingo Taztingo marked this pull request as ready for review January 2, 2024 15:47
@Taztingo
Copy link
Contributor Author

Taztingo commented Jan 2, 2024 •
edited by Reecepbcups
Loading

I was able to get all e2e tests passing using the main branch of relayer. Unfortunately, there is no tag of this yet. Ran the following tests and everything seems to pass.

make test
make ictest-icq
make ictest-upgrade

Let me know if there is any other tests that I can run.

Reecepbcups
Reecepbcups reviewed Jan 2, 2024
View reviewed changes
.github/workflows/async-icq.yml Outdated Show resolved Hide resolved
modules/async-icq/e2e/icq_test.go Outdated Show resolved Hide resolved
modules/async-icq/e2e/upgrade_test.go Show resolved Hide resolved
modules/async-icq/testing/demo-simapp/scripts/protocgen.sh Outdated Show resolved Hide resolved
modules/async-icq/testing/previous_images/README.md Outdated Show resolved Hide resolved
modules/async-icq/types/codec.go Show resolved Hide resolved
modules/async-icq/testing/simapp/upgrades/upgrades.go Outdated Show resolved Hide resolved
modules/async-icq/testing/simapp/export.go Outdated Show resolved Hide resolved
@Reecepbcups
Copy link
Member

Reecepbcups commented Jan 2, 2024 •
edited
Loading

@Taztingo if you can enable me to push to this branch that would be great 🙏 I can get some of these modifications in

@Taztingo
Copy link
Contributor Author

Taztingo commented Jan 3, 2024 •
edited
Loading

@Reecepbcups Would you actually be able to fork our repo, and create a PR onto taztingo/ibc-v8? I can pull that in asap and it will update this.

@Reecepbcups Reecepbcups mentioned this pull request Jan 4, 2024
Merged
@Reecepbcups
Copy link
Member

@Taztingo PR opened at provenance-io#1. Have tested locally and linted, all CI should pass

@Taztingo Taztingo requested a review from Reecepbcups January 4, 2024 13:53
@Reecepbcups
Copy link
Member

Looks good to me! I am going to merge and will fix the CI in another PR :) (I remember saving the 7.1.1.tar file, but must have forgot to commit it oops)

Thank you for your work on this!

@Reecepbcups Reecepbcups merged commit 18248c3 into cosmos:main Jan 4, 2024
4 of 7 checks passed
This was referenced Jan 4, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reecepbcups Reecepbcups Reecepbcups approved these changes

Assignees
No one assigned
Labels
async-icq Label for items related to the async-icq module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Taztingo @Reecepbcups