test: Fix total supply bug in test util GenesisStateWithValSet #23072
Conversation
📝 WalkthroughWalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: .coderabbit.yml 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)testutil/sims/app_helpers.go (1)Pattern 🔇 Additional comments (1)testutil/sims/app_helpers.go (1)
Multiplying
Consider running the following quick check to confirm the usage of the updated ✅ Verification successfulLet me gather more information about the total supply and bonded pool logic. Multiplication of bondAmt by delegations count is correctly implemented The verification shows that the total supply calculation is properly handled in the
The implementation maintains consistency between the bonded pool balance and total supply, and the function is used appropriately in test utilities across the codebase. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Quickly search for references to GenesisStateWithValSet and show context.
rg -A 5 'GenesisStateWithValSet'
Length of output: 1610 Script: #!/bin/bash
# Check for any supply or bonded pool related code in the test utilities
rg -A 5 "bondAmt|BondDenom|TotalSupply|BondedPool" testutil/
# Check for any genesis state modifications related to bonding
ast-grep --pattern 'func GenesisStateWithValSet($$$) {
$$$
}'
Length of output: 4756 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
| @@ -273,7 +273,7 @@ func GenesisStateWithValSet( | |||
| // add bonded amount to bonded pool module account | |||
| balances = append(balances, banktypes.Balance{ | |||
| Address: authtypes.NewModuleAddress(stakingtypes.BondedPoolName).String(), | |||
| Coins: sdk.Coins{sdk.NewCoin(sdk.DefaultBondDenom, bondAmt)}, | |||
| Coins: sdk.Coins{sdk.NewCoin(sdk.DefaultBondDenom, bondAmt.MulRaw(int64(len(delegations))))}, | |||
There was a problem hiding this comment.
Before, was assuming that there is only one delegation (to one validator). But if multiple validators are specified, they get one delegation each.
Description
Very small change, so it's easier to check the files changed.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
confirmed!in the type prefix if API or client breaking changeprovided a link to the relevant issue or specificationincluded the necessary unit and integration testsadded a changelog entry toCHANGELOG.mdupdated the relevant documentation or specification, including comments for documenting Go codeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit