Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos in documentation files #23063

Merged
merged 1 commit into from
Dec 23, 2024
Merged

docs: fix typos in documentation files #23063

merged 1 commit into from
Dec 23, 2024

Conversation

vtjl10
Copy link
Contributor

@vtjl10 vtjl10 commented Dec 22, 2024

Corrected were to where x2
Corrected hun to hub

Summary by CodeRabbit

  • Documentation
    • Updated the 04-rosetta.md document for improved clarity and corrected typographical errors.
    • Corrected the path for the example plugin from plugins/cosmos-hun/ to plugins/cosmos-hub/.

@vtjl10 vtjl10 requested a review from a team as a code owner December 22, 2024 15:20
Copy link
Contributor

coderabbitai bot commented Dec 22, 2024

📝 Walkthrough

Walkthrough

The pull request involves minor documentation updates to the 04-rosetta.md file in the user documentation. The changes are primarily typographical corrections, including fixing two instances of "were" to "where" and correcting a plugin path from plugins/cosmos-hun/ to plugins/cosmos-hub/. These modifications aim to improve the document's readability and accuracy without altering the technical content or functionality of the instructions.

Changes

File Change Summary
docs/user/run-node/04-rosetta.md - Corrected typographical errors ("were" → "where")
- Fixed plugin path from plugins/cosmos-hun/ to plugins/cosmos-hub/

Possibly related PRs

Suggested reviewers

  • sontrinh16
  • julienrbrt

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
docs/user/run-node/04-rosetta.md (2)

79-79: Improve grammar and hyphenation in the plugin setup description.

The sentence structure needs improvement, and compound modifiers should be hyphenated.

-To use Rosetta over any chain, it is required to set up prefixes and registering zone specific interfaces through plugins.
+To use Rosetta over any chain, you need to set up prefixes and register zone-specific interfaces through plugins.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~79-~79: This verb may not be in the correct form. Consider using a different form for this context.
Context: ..., it is required to set up prefixes and registering zone specific interfaces through plugin...

(AI_EN_LECTOR_REPLACEMENT_VERB_FORM)


[uncategorized] ~79-~79: When ‘zone-specific’ is used as a modifier, it is usually spelled with a hyphen.
Context: ...ired to set up prefixes and registering zone specific interfaces through plugins. Each plugi...

(SPECIFIC_HYPHEN)


81-83: Improve formatting and punctuation in the implementation details.

Several formatting and punctuation improvements are needed:

  1. Hyphenate compound modifiers
  2. Add Oxford comma
  3. Use consistent list markers (asterisks instead of dashes)
-Each plugin is a minimalist implementation of `InitZone` and `RegisterInterfaces` which allow Rosetta to parse chain specific data. There is an example for cosmos-hub chain under `plugins/cosmos-hub/` folder
-- **InitZone**: An empty method that is executed first and defines prefixes, parameters and other settings.
-- **RegisterInterfaces**: This method receives an interface registry which is where the zone specific types and interfaces will be loaded
+Each plugin is a minimalist implementation of `InitZone` and `RegisterInterfaces` which allow Rosetta to parse chain-specific data. There is an example for cosmos-hub chain under `plugins/cosmos-hub/` folder
+* **InitZone**: An empty method that is executed first and defines prefixes, parameters, and other settings.
+* **RegisterInterfaces**: This method receives an interface registry, which is where the zone-specific types and interfaces will be loaded
🧰 Tools
🪛 LanguageTool

[uncategorized] ~81-~81: When ‘chain-specific’ is used as a modifier, it is usually spelled with a hyphen.
Context: ...nterfaces` which allow Rosetta to parse chain specific data. There is an example for cosmos-hu...

(SPECIFIC_HYPHEN)


[uncategorized] ~83-~83: Possible missing comma found.
Context: ...es**: This method receives an interface registry which is where the zone specific types ...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~83-~83: When ‘zone-specific’ is used as a modifier, it is usually spelled with a hyphen.
Context: ...n interface registry which is where the zone specific types and interfaces will be loaded In...

(SPECIFIC_HYPHEN)

🪛 Markdownlint (0.37.0)

82-82: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


83-83: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


82-82: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e66b383 and 7b2af67.

📒 Files selected for processing (1)
  • docs/user/run-node/04-rosetta.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docs/user/run-node/04-rosetta.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

🪛 LanguageTool
docs/user/run-node/04-rosetta.md

[uncategorized] ~79-~79: This verb may not be in the correct form. Consider using a different form for this context.
Context: ..., it is required to set up prefixes and registering zone specific interfaces through plugin...

(AI_EN_LECTOR_REPLACEMENT_VERB_FORM)


[uncategorized] ~79-~79: When ‘zone-specific’ is used as a modifier, it is usually spelled with a hyphen.
Context: ...ired to set up prefixes and registering zone specific interfaces through plugins. Each plugi...

(SPECIFIC_HYPHEN)


[uncategorized] ~81-~81: When ‘chain-specific’ is used as a modifier, it is usually spelled with a hyphen.
Context: ...nterfaces` which allow Rosetta to parse chain specific data. There is an example for cosmos-hu...

(SPECIFIC_HYPHEN)


[uncategorized] ~83-~83: Possible missing comma found.
Context: ...es**: This method receives an interface registry which is where the zone specific types ...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~83-~83: When ‘zone-specific’ is used as a modifier, it is usually spelled with a hyphen.
Context: ...n interface registry which is where the zone specific types and interfaces will be loaded In...

(SPECIFIC_HYPHEN)

🪛 Markdownlint (0.37.0)
docs/user/run-node/04-rosetta.md

82-82: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


83-83: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


82-82: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

🔇 Additional comments (1)
docs/user/run-node/04-rosetta.md (1)

81-81: LGTM: Plugin path is correctly updated.

The plugin path is now correctly specified as plugins/cosmos-hub/.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~81-~81: When ‘chain-specific’ is used as a modifier, it is usually spelled with a hyphen.
Context: ...nterfaces` which allow Rosetta to parse chain specific data. There is an example for cosmos-hu...

(SPECIFIC_HYPHEN)

@julienrbrt julienrbrt changed the title fix: typos in documentation files docs: fix typos in documentation files Dec 23, 2024
@tac0turtle tac0turtle enabled auto-merge December 23, 2024 11:47
@tac0turtle tac0turtle added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Dec 23, 2024
@tac0turtle tac0turtle added this pull request to the merge queue Dec 23, 2024
auto-merge was automatically disabled December 23, 2024 11:58

Pull Request is not mergeable

auto-merge was automatically disabled December 23, 2024 11:58

Pull Request is not mergeable

Merged via the queue into cosmos:main with commit d1f9fd8 Dec 23, 2024
72 of 77 checks passed
mergify bot pushed a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants