Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare v2 beta (3/3) #23034

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore: prepare v2 beta (3/3) #23034

merged 1 commit into from
Dec 20, 2024

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Dec 20, 2024

Description

Follow-up of #23032

Tagged https://github.com/cosmos/cosmos-sdk/releases/tag/server%2Fv2.0.0-beta.1.

once changes are backported, I can tag server/v2/cometbft (from release/v0.52.x (!)) and we have a v2 beta :)
Main has replaces, so this is why the go.sum isn't updated. However the backport will be properly updated.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Updated several dependencies to their latest beta versions, enhancing compatibility and stability.
  • Bug Fixes

    • Addressed potential issues by transitioning to beta versions of key modules, which may include important fixes and improvements.

@julienrbrt julienrbrt added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Dec 20, 2024
@julienrbrt julienrbrt requested a review from a team as a code owner December 20, 2024 09:18
Copy link
Contributor

coderabbitai bot commented Dec 20, 2024

📝 Walkthrough

Walkthrough

This pull request focuses on updating dependency versions in go.mod files for two modules: cosmossdk.io/server/v2/cometbft and cosmossdk.io/simapp/v2. The primary changes involve transitioning several dependencies to beta versions, specifically cosmossdk.io/server/v2, cosmossdk.io/server/v2/stf, and cosmossdk.io/store/v2. These updates suggest a coordinated effort to align module versions across the Cosmos SDK ecosystem, preparing for a potential beta release.

Changes

File Changes
server/v2/cometbft/go.mod - Updated cosmossdk.io/server/v2 to v2.0.0-beta.1
- Updated cosmossdk.io/server/v2/stf to v1.0.0-beta.1
- Updated cosmossdk.io/store/v2 to v2.0.0-beta.1
simapp/v2/go.mod - Updated cosmossdk.io/server/v2 to v2.0.0-beta.1

Possibly related PRs

Suggested labels

C:server/v2, C:server/v2 cometbft

Suggested reviewers

  • sontrinh16
  • akhilkumarpilli
  • kocubinski

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5765cee and 938ebac.

📒 Files selected for processing (2)
  • server/v2/cometbft/go.mod (1 hunks)
  • simapp/v2/go.mod (1 hunks)
🔇 Additional comments (2)
server/v2/cometbft/go.mod (1)

24-27: LGTM! Version updates align with v2 beta preparation.

The dependency version updates are consistent with the PR objective of preparing for v2 beta release. All critical dependencies have been updated to their respective beta versions.

Let's verify the version consistency across related dependencies:

✅ Verification successful

Version consistency verified across all v2 beta dependencies

The verification shows consistent version usage across all go.mod files in the repository:

  • cosmossdk.io/server/v2: v2.0.0-beta.1
  • cosmossdk.io/server/v2/appmanager: v1.0.0-beta.1
  • cosmossdk.io/server/v2/stf: v1.0.0-beta.1
  • cosmossdk.io/store/v2: v2.0.0-beta.1
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check version consistency across related v2 beta dependencies
# Look for any mismatched versions that might cause compatibility issues

rg -g 'go.mod' "cosmossdk.io/(server|store)/v2.*beta" 

Length of output: 1008

simapp/v2/go.mod (1)

14-14: LGTM! Server v2 version update is consistent.

The update to cosmossdk.io/server/v2 v2.0.0-beta.1 aligns with the version in server/v2/cometbft/go.mod and the PR's objective of preparing for v2 beta release.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@julienrbrt julienrbrt enabled auto-merge December 20, 2024 09:22
@julienrbrt julienrbrt added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 5856fb6 Dec 20, 2024
79 of 80 checks passed
@julienrbrt julienrbrt deleted the julien/v2-beta branch December 20, 2024 09:32
mergify bot pushed a commit that referenced this pull request Dec 20, 2024
(cherry picked from commit 5856fb6)

# Conflicts:
#	server/v2/cometbft/go.mod
#	simapp/v2/go.mod
julienrbrt added a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release C:server/v2 cometbft C:server/v2 Issues related to server/v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants