Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add order_migrations argument in runtime.Module config (backport: #14213) #19339

Closed

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Feb 3, 2024

#14213)

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@mmsqe mmsqe requested a review from a team as a code owner February 3, 2024 01:40
@julienrbrt
Copy link
Member

I don't think we need this to be backported 👀
Which version of cosmossdk.io/api are you using if you are missing this? Version v0.3.1 should have it (https://pkg.go.dev/cosmossdk.io/[email protected]/cosmos/app/runtime/v1alpha1#Module).

Or is it because it isn't in the buf tag 0.47.0 (https://buf.build/cosmos/cosmos-sdk/docs/v0.47.0:cosmos.app.runtime.v1alpha1).

@mmsqe
Copy link
Contributor Author

mmsqe commented Feb 3, 2024

I don't think we need this to be backported 👀 Which version of cosmossdk.io/api are you using if you are missing this? Version v0.3.1 should have it (https://pkg.go.dev/cosmossdk.io/[email protected]/cosmos/app/runtime/v1alpha1#Module).

Or is it because it isn't in the buf tag 0.47.0 (https://buf.build/cosmos/cosmos-sdk/docs/v0.47.0:cosmos.app.runtime.v1alpha1).

I see, might related to my go.work

@mmsqe mmsqe closed this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants