Switch WYSIWYG button is too close to the top. #170
Conversation
It partly covers the first line of the intro text.
|
I don't exactly remember how it's implemented, but when I made my styling changes I made them with mostly the Argon/Krypton theme in mind. Whether the button is too high or not will always depend on the theme around it, so longer term the switching button should be integrated into the editor buttons instead, IMO. |
|
Ok, I'm just using the standard theme. I agree that the way the button is implemented is a little bit of a kludge as it is more-or-less impossible to position it in a theme-agnostic way. OTOH, integrating it in the editor buttons would imply that also the standard editor needs to have a switch-editor button, or at least an extension point. So maybe we close this pull request and rather add an issue "refactor switch-editor button" or something like this. |
I guess it makes sense to do both. I find it reasonable that the button should look the best in the default theme. Such an issue has already existed with #92. Maybe it could be reopened (or another one created, sure). FYI, in my development repository I already have an issue for further reworking of button. It would go along well with fablab-luenen#9. These issues are in my own repository because I meant to work on them myself, don't want to impose my vision on anyone, and, tbh, because this repository seems a bit unmaintained. Would you be interested in working on these? I haven't been able to allocate many development resources to this project lately. |
|
I noticed that in narrower configurations the button with your settings also seems to cover the text: There are really not many ways around this without a proper rework, I think. The only workaround I can think of would be moving the button even higher and to the left (
... but that too is not very elegant, IMO. A proper workaround to get the button into the layout flow would require changing the location at which it is injected. Currently it is at the end of the editor ...
... a better location might be behind the intro paragraph ...
... or inside it.
This would still be worth doing despite "properly" reworking the button, since it will be needed when the visual editor isn't active. My favorite would be something like this: since the visual editor should be very easy to enter, but a bit harder to leave (it should be the preferred mode of editing, after all). A textual explanation would probably also do some good for confused users (really, nobody should be able to get stuck in markup mode):
|
|
Fixed. |
It partly covers the first line of the intro text.