Hmac with precomputed key #396
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix, we get error in debug mode (when assert is enabled):
```
hkdf.cpp:61:58: error: comparison between signed and unsigned integer
expressions [-Werror=sign-compare]
assert(out_len == EVP_MD_size(digest) && out_len == outputLen);
```
fabrice102
force-pushed
the
hmac-with-precomputed-key
branch
2 times, most recently
from
af3f66e to
881ffef
Compare
fabrice102
force-pushed
the
hmac-with-precomputed-key
branch
2 times, most recently
from
50bcab8 to
39e6205
Compare
This commit adds support for HMAC Precomputed Keys in ACCP. See aws/aws-lc#1574
fabrice102
force-pushed
the
hmac-with-precomputed-key
branch
from
39e6205 to
8097f53
Compare
bssl::ScopedHMAC_CTX simplifies HMAC context management. But it does not seem available in legacy builds. (The CB AccpCiLegacyTests fails.)
geedo0
previously approved these changes
Sep 27, 2024
WillChilds-Klein
previously approved these changes
Dec 9, 2024
src/com/amazon/corretto/crypto/provider/AmazonCorrettoCryptoProvider.java
Outdated
Show resolved
Hide resolved
Minor code improvements addressing comments from PR corretto#396.
fabrice102
dismissed stale reviews from WillChilds-Klein and geedo0
via
d596fbf
WillChilds-Klein
approved these changes
Dec 11, 2024
geedo0
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
This commit adds support for HMAC Precomputed Keys in ACCP.
See aws/aws-lc#1574
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.