Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to school names as of FA24 #188

Merged
merged 1 commit into from
Aug 20, 2024
Merged

changes to school names as of FA24 #188

merged 1 commit into from
Aug 20, 2024

Conversation

JustKong13
Copy link
Contributor

Summary

LSC reached out to us with an updated list of schools, and this PR addresses that new updated list. The add-test-data.ts file has also been updated so that test data reflects these new changes.

Test Plan

Notes

Breaking Changes

  • Database schema change (anything that changes Firestore collection structure)
  • Other change that could cause problems (Detailed in notes)

@JustKong13 JustKong13 requested a review from a team as a code owner August 19, 2024 19:36
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 12.

Copy link

Visit the preview URL for this PR (updated for commit ddfc3eb):

https://zing-lsc--pr188-update-school-names-w4x9n128.web.app

(expires Mon, 26 Aug 2024 19:38:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1fc18307b178c916e2663810a6932f60b173c01b

Copy link
Contributor

@rgu0114 rgu0114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link
Member

@Coreball Coreball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@JustKong13 JustKong13 merged commit 5b94bc9 into main Aug 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants