Metrics now automatically update with new semesters #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 17. |
|
Visit the preview URL for this PR (updated for commit 86c7523): https://zing-lsc--pr186-sp24-metric-tg2573cy.web.app (expires Thu, 22 Feb 2024 05:22:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1fc18307b178c916e2663810a6932f60b173c01b |
JustKong13
changed the title
rgu0114
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Great work on this PR Justin, thanks for continuing to make the Zing codebase extensible and more self-sufficient for the future! The functionality looks good – the only thing I would note is that admin users are able to enter negative numbers for the year, but that's okay for now/can be addressed in a future PR. Overall though, this looks great and I liked the simplicity in your solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously when we moved to a new semester, someone needed to manually change the codebase in order to make that semester available to be viewed on the metrics page.
Test Plan
Originally on the metrics page there isn't an option for Spring 25.
I can now add the Spring 25 semester via the settings.
And now it is available as an option.
Notes
The dropdown menu of the metrics page has the abbreviation semester "SP", rather than the the fully spelled out word "spring".
Breaking Changes