Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for Winter 24 #184

Closed
wants to merge 3 commits into from
Closed

Bug fixes for Winter 24 #184

wants to merge 3 commits into from

Conversation

JustKong13
Copy link
Contributor

@JustKong13 JustKong13 commented Jan 3, 2024

Summary

This pull request fixes a few bugs and prepares LSC for the winter semester, as well as

  • Dashboard no longer preloads spring 23
  • Fixed Email Regex to have to end with cornell.edu
  • Added winter '24 semester to metrics

Test Plan

Metrics page also has winter '24 as a valid option
Screenshot 2024-01-03 at 5 16 22 PM

Now correctly identifies invalid emails
Screenshot 2024-01-03 at 5 15 37 PM

Notes

In the future we will need to make the metrics semesters update automatically.

Breaking Changes

@JustKong13 JustKong13 requested a review from a team as a code owner January 3, 2024 22:16
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Justin Kong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 7.

Copy link

github-actions bot commented Jan 3, 2024

Visit the preview URL for this PR (updated for commit fc9bc36):

https://zing-lsc--pr184-winter-24-m4j9ktap.web.app

(expires Wed, 10 Jan 2024 22:42:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1fc18307b178c916e2663810a6932f60b173c01b

@JustKong13 JustKong13 closed this Jan 3, 2024
@JustKong13 JustKong13 reopened this Jan 3, 2024
@JustKong13 JustKong13 closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants