Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive FA24 and Add Script to Generate JSON #809

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

andrew032011
Copy link
Collaborator

@andrew032011 andrew032011 commented Dec 23, 2024

Summary

Archive all active members from Fall 2024 into fa24.json.

Add a script to do this, runnable through

yarn workspace backend run create-member-archive <semester>

i.e.

yarn workspace backend run create-member-archive fa24

Notion/Figma Link

Test Plan

Ran the above command to generate the archive.

Notes

Breaking Changes

@andrew032011 andrew032011 requested a review from a team as a code owner December 23, 2024 14:23
@dti-github-bot
Copy link
Member

dti-github-bot commented Dec 23, 2024

[diff-counting] Significant lines: 18.

Copy link
Contributor

@cchrischen cchrischen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks goood! do we have the sp23 archive?

Copy link
Contributor

@cchrischen cchrischen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing lol


approvedMemberCollection.get().then(async (colRef) => {
const members = await Promise.all(colRef.docs.map((doc) => doc.data()));
fs.writeFileSync('src/members-archive/fa24.json', JSON.stringify({ members }, undefined, 2));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have the write path json's file name come from command line args?

@andrew032011 andrew032011 merged commit 7d06e15 into main Dec 31, 2024
13 of 17 checks passed
@andrew032011 andrew032011 deleted the axc/archive_fa24.json branch December 31, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants