WIP: fix UI issues presented in UI audit #967
Conversation
|
[diff-counting] Significant lines: 41. |
|
Visit the preview URL for this PR (updated for commit d7ec5ca): https://cornelldti-courseplan-dev--pr967-fix-clement-audit-is-fh5gqygi.web.app (expires Mon, 30 Dec 2024 06:22:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
| @@ -313,7 +313,6 @@ input { | |||
| border-top: 1px solid #e5e5e5; | |||
| box-sizing: border-box; | |||
| box-shadow: 0px 0px 4px rgba(0, 0, 0, 0.25); | |||
There was a problem hiding this comment.
May want to check in with Joanna on the shadow CSS - we notice there were some inconsistencies across CoursePlan with this so we might as well fix them here
| @@ -389,10 +389,10 @@ input { | |||
| } | |||
| &-select { | |||
| background: $white; | |||
| border: 1px solid $inactiveGray; | |||
| border: 0.5px solid $inactiveGray; | |||
There was a problem hiding this comment.
Like the rest of these fixes, thanks for paying such close attention here! I'm glad we're getting on top of these UI changes so soon
| @@ -8,7 +8,7 @@ input { | |||
| background-color: none; | |||
| } | |||
| .onboarding { | |||
| padding: 1rem; | |||
| padding: 2rem 1rem; | |||
There was a problem hiding this comment.
I think there are a lot of Profile + Onboarding css changes that we'll have due to the UI revamp next sem - may need to put changes in those files on hold for now
Summary
This is a work in progress PR that fixes some of the UI issues presented in Clément's UI audit.