Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state management for map markers and circles in GameplayMap #237

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

3TTemi
Copy link
Contributor

@3TTemi 3TTemi commented Dec 9, 2024

Summary

  1. This pull request first addresses the issue where the challenge location does not refresh when initially null, often defaulting to a fallback location. The changes ensure that the map dynamically updates to reflect the correct challenge location.
  • Implemented state management for map markers and circles to handle dynamic updates.
  • Updated _updateMapMarkers to refresh markers and circles when targetLocation changes.
  1. This pull request also addresses behavior where the map area is pushed to splash page but it is nested in the gameplay page still.
  • Remove the StreamBuilder from GameplayMap entirely to remove duplicate handling with BottomNavBar

Remaining TODOs:

  • Integrated markers and circles with the GoogleMap widget to ensure accurate location representation.

Test Plan

Test the map's behavior when targetLocation is initially null and later updated to ensure it reflects the correct location.

Confirm that the map does not default to the fallback location once the targetLocation is set.

Ensure disconnecting from gameplay bring users back to splash page without any nested elements

@dti-github-bot
Copy link
Member

dti-github-bot commented Dec 9, 2024

[diff-counting] Significant lines: 90.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants