Filter out drivers in Reassign drivers for scheduled rides based on availability. #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 78. |
Atikpui007
previously approved these changes
May 6, 2024
| // You can add additional filters to filter our drivers to reassign here. | ||
| const reassignDriverFilters: ((driver: DriverType) => boolean)[] = [ | ||
| // (driver: DriverType) => { | ||
| // return driver.firstName != 'Bin laden'; |
There was a problem hiding this comment.
Please dont add this lol
Specifically line 42. Change the first name example
There was a problem hiding this comment.
Yup, forgot to removed it when I was messing around. Changed it now tho.
There was a problem hiding this comment.
Don't forget to push your changes 🙏 The test driver name is still there lol
|
I refactored the code to make some functions like isAvaiable (which might be useful in other contexts) exportable and added some needed documentation. Tested everything informatlly and it works. Also resolved any merge conflicts with the master branch at the time of writing this comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When you reassign driver for scheduled rides, it will only show the drivers available. Additionally, you add can more filters into an array called reassignDriverFilters.
Test Plan
I have tested this very informally using console.log but plan to do more rigrous testing with unit tests in the future (after finals).