Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image build #100

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Fix image build #100

merged 2 commits into from
Jan 2, 2024

Conversation

bzed
Copy link
Contributor

@bzed bzed commented Dec 22, 2023

Building the docker image failed on two issues:

  • since 8f29491 coraza.cfg didn't fit the coraza version anymore. It was only updated in the doc folder
  • haproxy starting with 2.3 requires a LF at the end of config files, that was also missing.

bzed added 2 commits December 23, 2023 00:48
@bzed
build image: use coraza.cfg as updated in 8f29491
a53c11e
@bzed
coraza.cfg: haproxy configs must end with a LF
56a7ace 
A missing LF on the end of config files is a hard error starting with
haproxy 2.3
@bzed
Copy link
Contributor Author

bzed commented Dec 22, 2023

https://github.com/bzed/coraza-spoa/actions/runs/7304780601/job/19907444704

@sts
Copy link
Contributor

sts commented Dec 23, 2023

LGTM!

@fzipi fzipi merged commit b93d995 into corazawaf:main Jan 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzed @sts @fzipi