spec: add optional secrets to NodeGetVolumeStatsRequest #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
force-pushed
the
NodeGetVolumeStats/secrets
branch
from
69d9704 to
f2d012b
Compare
nixpanic
force-pushed
the
NodeGetVolumeStats/secrets
branch
from
f2d012b to
bc856b1
Compare
nixpanic
force-pushed
the
NodeGetVolumeStats/secrets
branch
from
bc856b1 to
5e3def1
Compare
For BlockVolume type of volumes, there are very little stats that can be gathered. The only reasonable metric on the Node that is available without knowing the contents of the BlockVolume, is the Total capacity. Different backend storage systems can thin-provision BlockVolumes. Initially the Used storage will be low, and growing over time. This is not detectable through standard Operating System APIs, but the backend storage system can provide more acurate Available/Used stats through expert APIs. In order to allow the Node to retrieve advanced stats from the backend storage system, the secrets that are used for staging the volume can be provided.
nixpanic
force-pushed
the
NodeGetVolumeStats/secrets
branch
from
5e3def1 to
a86141d
Compare
|
Rebased on top of the master branch to resolve some conflicts. This is still something we're interested in so that Ceph-CSI can detect the actual consumed space of (thin-provisioned) BlockVolumes instead of the size of the block-device. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For BlockVolume type of volumes, there are very little stats that can be
gathered. The only reasonable metric on the Node that is available
without knowing the contents of the BlockVolume, is the Total capacity.
Different backend storage systems can thin-provision BlockVolumes.
Initially the Used storage will be low, and growing over time. This is
not detectable through standard Operating System APIs, but the backend
storage system can provide more acurate Available/Used stats through
expert APIs.
In order to allow the Node to retrieve advanced stats from the backend
storage system, the secrets that are used for staging the volume can be
provided.
Fixes: #371