Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated spec.md with few rewordings. #391

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated spec.md with few rewordings. #391

wants to merge 1 commit into from

Conversation

ashish-billore
Copy link

Updated few lines to make the meaning more explicit.

@ashish-billore
Updated spec.md with few rewordings.
5bb0764 
Updated few lines to make the meaning more explicit.
@ashish-billore ashish-billore requested a review from jdef September 28, 2019 01:22
@ashish-billore
Copy link
Author

Thanks @jdef for review and approval.
If these changes look good, could this PR be merged?
Thanks!

saad-ali
saad-ali approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@saad-ali saad-ali left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@ashish-billore can you please sign the CLA: https://github.com/container-storage-interface/spec/blob/master/CONTRIBUTING.md#licence-and-cla

@ashish-billore
Copy link
Author

ashish-billore commented Oct 23, 2019 •
edited
Loading

Thanks @saad-ali for review.
The email link (https://github.com/container-storage-interface/spec/blob/master/[email protected]) in above CLA document seems to be broken.

Also, the CLA doc above is a pdf form, so does it need to be printed, filled/signed and scanned to be sent to [email protected]?
Is there an alternate, online way to sign the CLA?

@saad-ali
Copy link
Member

@ashish-billore unfortunately it's a manual process right now. You'd have to print sign and email the CLA to [email protected]

@saad-ali saad-ali mentioned this pull request May 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali saad-ali approved these changes

@jdef jdef jdef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashish-billore @saad-ali @jdef