Specify minimum needed R version in DESCRIPTION (#136)

* Specify minimum needed R version in DESCRIPTION * Update test-vdiffr.R * remove unnecessary cran skips * update README
const-ae · May 7, 2024 · ee11236 · ee11236
1 parent 6e9c62e
commit ee11236
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 17 deletions.
diff --git a/.github/workflows/check-full.yaml b/.github/workflows/check-full.yaml
@@ -1,9 +1,3 @@
-# Workflow derived from https://github.com/r-lib/actions/tree/v2/examples
-# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
-#
-# NOTE: This workflow is overkill for most R packages and
-# check-standard.yaml is likely a better choice.
-# usethis::use_github_action("check-standard") will install it.
 on:
   push:
     branches: [main, master]
@@ -30,13 +24,13 @@ jobs:
           - { os: windows-latest, r: "release" }
           - { os: windows-latest, r: "oldrel-1" }
 
-          # Use older ubuntu to maximise backward compatibility
           - { os: ubuntu-latest, r: "devel", http-user-agent: "release" }
           - { os: ubuntu-latest, r: "release" }
           - { os: ubuntu-latest, r: "oldrel-1" }
           - { os: ubuntu-latest, r: "oldrel-2" }
           - { os: ubuntu-latest, r: "oldrel-3" }
           - { os: ubuntu-latest, r: "oldrel-4" }
+          - { os: ubuntu-latest, r: "3.6" }
 
     env:
       GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}

diff --git a/.gitignore b/.gitignore
@@ -50,3 +50,4 @@ revdep/library.noindex
 revdep/data.sqlite
 /doc/
 /Meta/
+tests/testthat/Rplots.pdf
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -31,13 +31,15 @@ VignetteBuilder:
     knitr
 Encoding: UTF-8
 Language: en-US
+Depends: 
+    R (>= 3.6.0)
 Imports:
     ggplot2 (>= 3.5.0)
 Suggests: 
     knitr,
     rmarkdown,
     testthat,
-    vdiffr (>= 1.0.5)
+    vdiffr (>= 1.0.7)
 Roxygen: list(markdown = TRUE, roclets = c("rd", "namespace", "collate"))
 RoxygenNote: 7.3.1
 Config/testthat/edition: 3

diff --git a/README.Rmd b/README.Rmd
@@ -5,7 +5,7 @@ output: github_document
 # ggsignif: Significance Brackets for 'ggplot2' <a href='https://github.com/const-ae/ggsignif'><img src='man/figures/logo.svg' align="right" height="209" /></a>
 
 [![CRAN_Status_Badge](https://www.r-pkg.org/badges/version/ggsignif)](https://cran.r-project.org/package=ggsignif)
-[![R build status](https://github.com/const-ae/ggsignif/workflows/R-CMD-check/badge.svg)](https://github.com/const-ae/ggsignif)
+[![R build status](https://github.com/const-ae/ggsignif/workflows/R-CMD-check/badge.svg)](https://github.com/const-ae/ggsignif/actions)
 [![Total downloads badge](https://cranlogs.r-pkg.org/badges/grand-total/ggsignif?color=blue)](https://CRAN.R-project.org/package=ggsignif)
 [![Codecov test coverage](https://codecov.io/gh/const-ae/ggsignif/branch/main/graph/badge.svg)](https://app.codecov.io/gh/const-ae/ggsignif?branch=main)
 [![lifecycle](https://img.shields.io/badge/lifecycle-stable-brightgreen.svg)](https://lifecycle.r-lib.org/articles/stages.html)

diff --git a/README.md b/README.md
@@ -3,7 +3,7 @@
 
 [![CRAN_Status_Badge](https://www.r-pkg.org/badges/version/ggsignif)](https://cran.r-project.org/package=ggsignif)
 [![R build
-status](https://github.com/const-ae/ggsignif/workflows/R-CMD-check/badge.svg)](https://github.com/const-ae/ggsignif)
+status](https://github.com/const-ae/ggsignif/workflows/R-CMD-check/badge.svg)](https://github.com/const-ae/ggsignif/actions)
 [![Total downloads
 badge](https://cranlogs.r-pkg.org/badges/grand-total/ggsignif?color=blue)](https://CRAN.R-project.org/package=ggsignif)
 [![Codecov test

diff --git a/tests/testthat/test-geom_signific_strict.R b/tests/testthat/test-geom_signific_strict.R
@@ -1,8 +1,4 @@
 test_that("the plotting works - strict test", {
-  # don't run on CRAN; allows ggplot2 people to make changes to internal dataframes
-  skip_on_cran()
-  skip_if(getRversion() < "4.0")
-
   library(ggplot2)
 
   dat <- data.frame(

diff --git a/tests/testthat/test-vdiffr.R b/tests/testthat/test-vdiffr.R
@@ -1,7 +1,4 @@
 test_that("plots are rendered correctly", {
-  skip_on_cran()
-  skip_if_not_installed("vdiffr")
-  skip_if(getRversion() < "4.1")
   library(ggplot2)
 
   set.seed(123)
-Original file line number
+Diff line change
@@ Expand Up / @@ -50,3 +50,4 @@ revdep/library.noindex @@
     revdep/data.sqlite
     /doc/
     /Meta/
+    tests/testthat/Rplots.pdf