Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding -f Mark reads as QCFAIL instead of excluding them to trim. #70

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FredDodd6
Copy link
Contributor

No description provided.

@FredDodd6 FredDodd6 changed the title adding -f Mark reads as QCFAIL instead of excluding them to to trim. adding -f Mark reads as QCFAIL instead of excluding them to trim. Sep 9, 2020
@FredDodd6 FredDodd6 marked this pull request as draft September 9, 2020 10:05
@dkj
Copy link
Contributor

dkj commented Sep 10, 2020

We're on hold with this as it still removes records that we would like to retain (but mark as QCFAIL) for reanalysis.

@m-bull
Copy link
Contributor

m-bull commented Sep 10, 2020

Good compromise might be to put it behind an option? Code written then, just need to update profile as required later?

@dkj
Copy link
Contributor

dkj commented Oct 8, 2020

@m-bull (sorry for the late reply) - I think the code will have to change to accommodate further change required in ivar...

@m-bull
Copy link
Contributor

m-bull commented Oct 8, 2020

No probs @dkj. I'm waiting on this too, so anticipating some tweaks pretty soon.

@gkarthik
Copy link

Hello all, with andersen-lab/ivar@29cf79d (resolving andersen-lab/ivar#73), in cases where the insert size is smaller than the read length, the read is treated an unpaired and both forward and reverse primers are trimmed off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants