-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark matrix for connect protocols #588
Conversation
7519fe5
to
4c609a7
Compare
Not super surprised, but it's nice to see that the Connect protocol is the most efficient unary implementation. |
@akshayjshah let me know what else is needed for this PR. Would be great to have for testing the changes to unary flows! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I wasn't sure about expanding the example PingServer implementation, but it's probably good to show how to implement all the different RPC types in the GoDoc.
Updated the commit description before merge. For posterity:
|
Previous benchmarks only tested gRPC clients. This extends the matrix for all protocols and each streaming type. Streams do a single req/rsp to make it easier to compare to unary flows.