Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Don't trigger handler signal on success #1234

Merged
merged 2 commits into from
Sep 17, 2024
Merged

V2: Don't trigger handler signal on success #1234

merged 2 commits into from
Sep 17, 2024

Conversation

srikrsna-buf
Copy link
Member

@srikrsna-buf srikrsna-buf commented Sep 16, 2024

Don't trigger handler signal on success. Implements the behavior highlighted in #1117 (comment).

This is a breaking change. In v1 the signal will always trigger on completion.

Signed-off-by: Sri Krishna Paritala <[email protected]>
Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the JSDoc on HandlerContext? E.g.

  /**
   * An AbortSignal that triggers when the deadline is reached, or when an
   * error occurs that aborts processing of the request.
   *
   * The signal can be used to automatically cancel downstream calls.
   */
  readonly signal: AbortSignal;

Signed-off-by: Sri Krishna Paritala <[email protected]>
@srikrsna-buf srikrsna-buf merged commit 25ca96e into v2 Sep 17, 2024
45 checks passed
@srikrsna-buf srikrsna-buf deleted the sk/handler branch September 17, 2024 09:32
@timostamm timostamm mentioned this pull request Sep 20, 2024
timostamm added a commit that referenced this pull request Oct 18, 2024
timostamm added a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants