Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] - Don't keep _version.py file in version control #998

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Nov 21, 2024

related to #969

As a pre req to taking up #861, clean up the _version.py file which should not be tracked in version control.

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 825d99c
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/673fc5f756018e000866b7bf

@peytondmurray
Copy link
Contributor

I like this, but is anyone using conda_store_server.__version__ right now? I guess as a workaround we can do something like

# conda_store_server/__init__.py

from importlib.metadata import version

__version__ = version(__package__)

if we need to...?

@soapy1
Copy link
Contributor Author

soapy1 commented Nov 22, 2024

The conda store version is meant to come from here https://github.com/conda-incubator/conda-store/blob/main/conda-store-server/conda_store_server/__init__.py#L17

As we move towards using setuptools-scm (and hatch-vcs), that'll look more like https://github.com/conda-incubator/conda-store/pull/861/files#diff-48a7f6b1b439ff32ff7b62092a2d6a49fb3c672e387714f659b6b492d22a3375R27.

Also want to call out this comment in the file

file generated by setuptools_scm
don't change, don't track in version control

@peytondmurray
Copy link
Contributor

Oh you're right - let's get rid of this!

@peytondmurray peytondmurray merged commit 16830f6 into conda-incubator:main Nov 22, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants