fix: handle None system metrics in user admin panel #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add default values for system metrics when None - Add conditional system metrics display in template - Show informative message when metrics unavailable Closes conda-incubator#1028
✅ Deploy Preview for conda-store canceled.
|
✅ Deploy Preview for conda-store canceled.
|
soapy1
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Sweet, thanks for this contribution!
Just a little suggestion about setting the default value of system_metrics.
There currently are not tests for views/ui.py and we plan on deprecating the admin app soon, so I think it's ok to not be adding tests for this.
conda-store-server/conda_store_server/_internal/server/views/ui.py
Outdated
Show resolved
Hide resolved
conda-store-server/conda_store_server/_internal/server/templates/user.html
Outdated
Show resolved
Hide resolved
soapy1
added
type: bug 🐛
- Return raw system_metrics from API without default values - Update user.html template to check for None metrics - Display info message when metrics not available Closes conda-incubator#1028
Done! |
soapy1
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1028