Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] - Improve release process #969

Closed
soapy1 opened this issue Nov 8, 2024 · 4 comments
Closed

[MAINT] - Improve release process #969

soapy1 opened this issue Nov 8, 2024 · 4 comments
Assignees
Labels
needs: discussion 💬 This item needs team-level discussion before scoping type: maintenance 🛠

Comments

@soapy1
Copy link
Contributor

soapy1 commented Nov 8, 2024

Context

Currently the release process for conda-store has a lot of manual tasks. It would be nice to automate some of the manual steps so that the release process is more streamlined. An ideal release process might looks something like

  1. check out the main branch, build and test locally
  2. create a tag in github for the release

Here, step 2 should do:

  • all the required version bumping for conda-store
  • pull the latest version number for conda-store-ui
  • run the automated tests
  • build and push all the relevant artifacts

Value and/or benefit

Makes cutting a release take less engineering time

Anything else?

No response

@soapy1 soapy1 added the needs: triaging 🚦 Someone needs to have a look at this issue and triage label Nov 8, 2024
@soapy1 soapy1 added needs: discussion 💬 This item needs team-level discussion before scoping type: maintenance 🛠 and removed needs: triaging 🚦 Someone needs to have a look at this issue and triage labels Nov 8, 2024
@soapy1 soapy1 moved this from New 🚦 to Ready 🛎️ in conda-store 🐍 Nov 8, 2024
@peytondmurray
Copy link
Contributor

all the required version bumping for conda-store

I'd vote for either hatch-vcs or setuptools_scm for versioning. Manually setting version strings is both unnecessary and is a recipe for human error, since they are tied precisely to the git tag we have most recently released. I know others feel differently about this, but I haven't yet been convinced that there's a reason not to use automated versioning.

In the release issue template for conda-store, there's a note about needing to make another PR to bump the conda-store and conda-store-server versions to the next dev-release number. This will not be needed if we use automated versioning.


We should also have a workflow that triggers on successful release publication which bumps the conda-store-server version in the conda-store-ui compose file.

@peytondmurray peytondmurray changed the title Improve release process [MAINT] - Improve release process Nov 8, 2024
@trallard
Copy link
Collaborator

While I am generally in favour of automating redundant manual steps I am -1 on fully automating the release of conda-store since I do not believe we have good enough confidence or coverage (not only of unit tests but also functional and integration tests) on our test suite and QA processes.

Here, step 2 should do:

all the required version bumping for conda-store

I started working on this in #861, though I did not complete this as I had to shift to other more urgent tasks and fixes.
TBH, some of the complexity comes from the fact that we are necessarily maintaining and releasing two packages. So, IMO, we should work on #911. This will reduce some of the maintenance and release toil (we use this as a mono repo and are separating the CLI from the API unnecessarily) and reduce the cognitive load on users.

We could see #861 to the end as this will avoid needing to bump the version to a development one through a PR (which was not being done until recently when I added this step to the release process), and would also fix the currently broken step of releasing dev versions to test-pypi on merge to main.

I'd vote for either hatch-vcs or setuptools_scm for versioning. Manually setting version strings is both unnecessary and is a recipe for human error, since they are tied precisely to the git tag we have most recently released. I know others feel differently about this, but I haven't yet been convinced that there's a reason not to use automated versioning.

This is precisely what such a PR should accomplish but as I mentioned before, this was stalled due to me needing to shift focus to make the most of the limited hours I can devote to conda-store.

pull the latest version number for conda-store-ui

This is something I think we should not automate. We have made broken releases -- as users mostly use conda-store through the UI and the fact that we do not have a robust or complete CLI or Python API -- due to the UI vendoring/integration with the REST API being broken and not being caught or tested through our CI or by the release captain. This leads to a poor end-user experience and additional maintenance toil. As recent as 2024.9.1, where we made a UI release that seemed completely functional and worked on its own, I realised this was not working when vendoring with conda-store-server through manual inspection, which led to several fixes needed on the UI to make a full release of conda-store + a newer version of the UI.

This is why I recently added more manual steps to encourage release captains to verify that the build works (which our CI already does) and that the vendor UI actually works with the current version of conda-store.
I recently added bits to enable using local builds of the UI to encourage and facilitate testing and development with a dev version of the UI. Though there are no tests (integration or functional) that do such a verification right now, these need adding first and should include Playwright (and visual test) to ensure everything is working as expected (since our current tests use the REST API as-is but do not rely on the UI per see).

run the automated tests
build and push all the relevant artifacts

This is already done.

@soapy1 soapy1 self-assigned this Nov 19, 2024
@soapy1 soapy1 moved this from Ready 🛎️ to TODO 📬 in conda-store 🐍 Nov 19, 2024
@soapy1
Copy link
Contributor Author

soapy1 commented Nov 25, 2024

I wrote this little bash script that automates the first bunch of steps of building a release https://github.com/conda-incubator/conda-store/compare/main...soapy1:conda-store:release-helper-workflow?expand=1 while #861 and #911 are in flight. Sharing in here in case anyone wants to use it.

@soapy1 soapy1 moved this from TODO 📬 to In Progress 🏗 in conda-store 🐍 Dec 3, 2024
@soapy1 soapy1 moved this from In Progress 🏗 to In review 👀 in conda-store 🐍 Dec 6, 2024
@soapy1
Copy link
Contributor Author

soapy1 commented Dec 9, 2024

I'm going to close this for now. Just merged #1006 which should make things easier. Can open a new issue for future improvements.

@soapy1 soapy1 closed this as completed Dec 9, 2024
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 💪🏾 in conda-store 🐍 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: discussion 💬 This item needs team-level discussion before scoping type: maintenance 🛠
Projects
Archived in project
Development

No branches or pull requests

3 participants